The logic change here makes it so that if the command passed intoshutil.which on windows, it will be verified against how it is passed in and against the various items in PATHEXT.

For example:

shutil.which('C:/windows/system32/cmd')

will now return

'C:/windows/system32/cmd.EXE'

Instead ofNone.

If this looks good, I'd be happy to create a changelog entry, etc. Just feeling the water with this first commit.

pythonGH-75586- Fix case where PATHEXT isn't applied to items in PAT…

01c152e

…H (Windows)

bedevere-bot added the awaiting review label

Apr 2, 2023

bedevere-bot mentioned this pull request

Apr 2, 2023

shutil.which doesn't find files without PATHEXT extension on Windows#75586

Closed

arhadthedev added OS-windows stdlibStandard Library Python modules in the Lib/ directory labels

Apr 2, 2023

arhadthedev changed the title~~GH-75586 - Fix case where PATHEXT isn't applied to items in PATH (Win…~~GH-75586: Fix case where PATHEXT isn't applied to items in PATH (Windows)

Apr 2, 2023

arhadthedev requested a review froma team

April 2, 2023 03:58

eryksun reviewed

Apr 2, 2023

View reviewed changes

Lib/shutil.py OutdatedShow resolvedHide resolved

csm10495 added2 commits

April 2, 2023 13:06

PR updates

0d4cd7b

Add tests

5fac84a

eryksun reviewed

Apr 2, 2023

View reviewed changes

Lib/shutil.py OutdatedShow resolvedHide resolved

eryksun reviewed

Apr 2, 2023

View reviewed changes

Lib/shutil.py OutdatedShow resolvedHide resolved

eryksun reviewed

Apr 2, 2023

View reviewed changes

Lib/shutil.py OutdatedShow resolvedHide resolved

eryksun reviewed

Apr 2, 2023

View reviewed changes

Lib/shutil.py OutdatedShow resolvedHide resolved

PR updates

fa145da

Copy link

ContributorAuthor

csm10495 commentedApr 2, 2023

@eryksun I think i fixed everything. Check again. Thanks!

csm10495and others added4 commits

April 2, 2023 15:00

line len fix

84a7976

📜🤖 Added by blurb_it.

63a06c4

Add changelog entry

7686a23

Double backticks

381e4fe

eryksun reviewed

Apr 2, 2023

View reviewed changes

Lib/shutil.py OutdatedShow resolvedHide resolved

csm10495and others added2 commits

April 2, 2023 15:36

Update Lib/shutil.py

e7c0b58

Co-authored-by: Eryk Sun <eryksun@gmail.com>

PR updates

26e3b15

eryksun reviewed

Apr 2, 2023

View reviewed changes

Lib/shutil.py OutdatedShow resolvedHide resolved

pep8 fix

6272b62

eryksun reviewed

Apr 2, 2023

View reviewed changes

Lib/test/test_shutil.py OutdatedShow resolvedHide resolved

eryksun reviewed

Apr 2, 2023

View reviewed changes

Lib/test/test_shutil.py OutdatedShow resolvedHide resolved

csm10495and others added2 commits

April 2, 2023 16:10

Update Lib/test/test_shutil.py

b6d29c8

Co-authored-by: Eryk Sun <eryksun@gmail.com>

Update Lib/test/test_shutil.py

1096cb7

Co-authored-by: Eryk Sun <eryksun@gmail.com>

eryksun added the 3.12only security fixes label

Apr 2, 2023

csm10495 requested a review fromzooba

April 4, 2023 16:52

eryksun reviewed

Apr 4, 2023

View reviewed changes

Lib/shutil.py OutdatedShow resolvedHide resolved

zooba reviewed

Apr 4, 2023

View reviewed changes

Lib/shutil.py OutdatedShow resolvedHide resolved

csm10495and others added2 commits

April 4, 2023 13:16

Update Lib/shutil.py

499d2de

Co-authored-by: Steve Dower <steve.dower@microsoft.com>

Add test for behavior

3ead780

Copy link

ContributorAuthor

csm10495 commentedApr 4, 2023

@zooba updated and added a corresponding test.

csm10495 requested a review fromzooba

April 4, 2023 20:27

Copy link

Member

zooba commentedApr 4, 2023

Looks good, and the tests all patch the call to that API so we shouldn't be impacted if the test machine has it configured differently.

Once CI passes, and unless someone else speaks up, I'll merge. Thanks for all your work on this!

Copy link

ContributorAuthor

csm10495 commentedApr 4, 2023

Got a doctest failure... The error is odd.. maybe its transient? I'll push an empty commit to see if it helps.

Testing of doctests in the sources finished, look at the results in build/doctest/output.txt.python: ./Include/internal/pycore_typeobject.h:75: _PyType_GetModuleState: Assertion `et->ht_module' failed.Aborted (core dumped)make[1]: *** [Makefile:49: build] Error 134make[1]: Leaving directory '/home/runner/work/cpython/cpython/Doc'Testing of doctests in the sources finished, look at the results in build/doctest/output.txtmake: *** [Makefile:127: doctest] Error 1make: Leaving directory '/home/runner/work/cpython/cpython/Doc'Error: Process completed with exit code 2.