Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-103092: Isolate _collections#103093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, I finished the remaining bits.
Now it crashes in the dict watcher deallocation, cc@carljm |
This comment was marked as outdated.
This comment was marked as outdated.
BTW, there are ref. leaks, so we need to hold off a little bit more. Try for example checking ref. leaks on |
bedevere-bot commentedApr 10, 2023
🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commit0dcfcef 🤖 If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again. |
bedevere-bot commentedApr 12, 2023
🤖 New build scheduled with the buildbot fleet by@kumaraditya303 for commit0381b45 🤖 If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
Good find! No ref.leaks locally over here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Final approval!
Good job! |
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.