Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-103092: Isolate _collections#103093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedMar 28, 2023
edited
Loading

Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, I finished the remaining bits.

erlend-aasland reacted with heart emoji
@kumaraditya303
Copy link
Contributor

Now it crashes in the dict watcher deallocation, cc@carljm

@erlend-aaslanderlend-aasland marked this pull request as ready for reviewApril 9, 2023 20:01
@erlend-aasland
Copy link
ContributorAuthor

Now it crashes in the dict watcher deallocation, cc@carljm

See45a26f3, which I believe is the correct prescription. Notice thatPyDict_Type.tp_init is called explicitly fromdefdict_init. IIRC, that is not needed, but I may be wrong (I'm unable to check that right now).

@erlend-aaslanderlend-aasland requested review fromkumaraditya303 and removed request forcarljmApril 9, 2023 22:41
@erlend-aasland

This comment was marked as outdated.

@erlend-aasland
Copy link
ContributorAuthor

BTW, there are ref. leaks, so we need to hold off a little bit more. Try for example checking ref. leaks ontest_defaultdict.

@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelApr 10, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commit0dcfcef 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelApr 10, 2023
@rhettingerrhettinger removed their request for reviewApril 11, 2023 17:44
@kumaraditya303kumaraditya303 added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 12, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@kumaraditya303 for commit0381b45 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 12, 2023
@erlend-aasland
Copy link
ContributorAuthor

Good find! No ref.leaks locally over here.

Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Final approval!

erlend-aasland reacted with laugh emojierlend-aasland reacted with heart emoji
@erlend-aasland
Copy link
ContributorAuthor

Good job!

@kumaraditya303kumaraditya303 merged commit52f96d3 intopython:mainApr 12, 2023
@kumaraditya303kumaraditya303 deleted the isolate-collections branchApril 12, 2023 12:51
aisk pushed a commit to aisk/cpython that referenced this pull requestApr 18, 2023
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@erlend-aasland@kumaraditya303@bedevere-bot@AlexWaygood

[8]ページ先頭

©2009-2025 Movatter.jp