Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-103085: Fix python locale.getencoding not to emit deprecation warning#103086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

youknowone
Copy link
Contributor

@youknowoneyouknowone commentedMar 28, 2023•
edited by bedevere-bot
Loading

Copy link
Member

@corona10corona10 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for catching this.
Here is a nit comment.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@youknowoneyouknowoneforce-pushed thelocale-getencoding-not-deprecated branch from7e74c5d to3f41d29CompareMarch 30, 2023 15:41
@youknowone
Copy link
ContributorAuthor

I have made the requested changes; please review again

Thank you for the review 😄

@bedevere-bot
Copy link

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

@corona10corona10 changed the titleGH-103085 Fix python locale.getencoding not to warns deprecatedGH-103085: Fix python locale.getencoding not to emit deprecation warning recursively.Mar 30, 2023
@corona10corona10 changed the titleGH-103085: Fix python locale.getencoding not to emit deprecation warning recursively.GH-103085: Fix python locale.getencoding not to emit deprecation warningMar 30, 2023
Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@corona10corona10 merged commit21e9de3 intopython:mainMar 30, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull requestApr 11, 2023
@youknowoneyouknowone deleted the locale-getencoding-not-deprecated branchJune 21, 2023 06:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@corona10corona10corona10 approved these changes

Assignees

@corona10corona10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@youknowone@bedevere-bot@corona10
[8]ページ先頭
©2009-2025 Movatter.jp