Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-103049: Support instruction level debugging in pdb#103050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
gaogaotiantian wants to merge10 commits intopython:main
base:main
Choose a base branch
Loading
fromgaogaotiantian:pdb-instruction-list

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantiangaogaotiantian commentedMar 27, 2023
edited by bedevere-bot
Loading

Copy link
Contributor

@artemmukhinartemmukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is one more thing I would like to mention. I think it would be better to useinstr instead ofinst as an abbreviation forinstruction, in both commands and source code. From what I have seen in the project,inst is also used forinstance, whereasinstr is primarily used for instruction.

@gaogaotiantian
Copy link
MemberAuthor

There is one more thing I would like to mention. I think it would be better to useinstr instead ofinst as an abbreviation forinstruction, in both commands and source code. From what I have seen in the project,inst is also used forinstance, whereasinstr is primarily used for instruction.

Usinginstr in the source code sounds like a good idea because that's howdis does it. However, ingdb andlldb, I think they just usestepi andnexti for the LONG version and that kind of makes sense. I think I'll go with that -si andstepi, do not usestepinst orstepinstr.

Copy link
Contributor

@artemmukhinartemmukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Usingstepi andnexti as long versions of commands makes sense for me as well 👍

gaogaotiantianand others added7 commitsApril 8, 2023 16:18
Co-authored-by: Artem Mukhin <ortem00@gmail.com>
Used stepi instead of stepinst(other commands too)Abstracted a function to restore caller trace function
Co-authored-by: Artem Mukhin <artem.m.mukhin@gmail.com>
@gaogaotiantiangaogaotiantian marked this pull request as ready for reviewApril 8, 2023 23:22
gaogaotiantianand others added2 commitsApril 9, 2023 11:06
Co-authored-by: Artem Mukhin <artem.m.mukhin@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@artemmukhinartemmukhinartemmukhin left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@gaogaotiantian@artemmukhin@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp