NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-101659: initialize stack variable _sharedexception#103048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

gaogaotiantian wants to merge1 commit intopython:mainfromgaogaotiantian:uninitialized-sharedexception

Closed

gh-101659: initialize stack variable _sharedexception#103048

gaogaotiantian wants to merge1 commit intopython:mainfromgaogaotiantian:uninitialized-sharedexception

Conversation

Copy link

Member

gaogaotiantian commentedMar 26, 2023•
edited by bedevere-bot
Loading

In./Modules/_xxsubinterpretersmodule.c a variable_sharedexception exc on stack is declared introduced in#102659. The variable is not initialized.

In_run_script, it's possible that the function hits an error and goes toerror label without properly initializing the variable. Then_sharedexception_bind can also potentially error out to trigger_sharedexception_clear(sharedexc), which may free the uninitialized pointer. I have not found an exploit on this, but there's a potential path. Also the fix is so easy and cheap so I think we can just initialize the variable withno_exception (basically{0}).

Oh BTW, gcc complains with the possible unitialized variable.

I would guess@ericsnowcurrently is the right person to review this? Thanks!