Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-60712: Include the "object" type in the lists of documented types#103036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
willingc merged 30 commits intopython:mainfromfurkanonder:issue-60712
Oct 30, 2024

Conversation

@furkanonder
Copy link
Contributor

@furkanonderfurkanonder commentedMar 25, 2023•
edited by terryjreedy
Loading

@terryjreedy
Copy link
Member

The original author was Martin Panter,@vadmium. I fixed the co-authorship note.

furkanonder reacted with thumbs up emoji

@terryjreedyterryjreedy requested review fromvadmium and removed request forEclips4March 29, 2023 17:56
@CAM-GerlachCAM-Gerlach added the docsDocumentation in the Doc dir labelMar 29, 2023
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Standard reminder: You can directly apply all the suggestions you want in one go by going toFiles changed -> ClickingAdd to batch on each suggestion -> When done, clickingCommit

Thanks! Various further textual, syntactic and formatting fixes.

furkanonder and blaisep reacted with thumbs up emoji
furkanonderand others added5 commitsMarch 30, 2023 12:48
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
furkanonderand others added3 commitsApril 1, 2023 01:12
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
'dictionaries' to 'dict'Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@terryjreedyterryjreedy self-assigned thisJun 18, 2023
Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have not reviewed changes to special methods section. Will make other changes on my local copy.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@furkanonderfurkanonder changed the titleGH-60712: Include the "object" type in the lists of documented typesgh-60712: Include the "object" type in the lists of documented typesAug 6, 2023
:term:`sequences <sequence>` (such as:class:`lists <list>` or
:class:`tuples <tuple>`) or:term:`mappings <mapping>` (like
:class:`dictionaries <dict>`),
:term:`dictionaries <dictionary>`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤔 Hm… on the line before, we see a general term used (with a link to glossary) and a concrete example in parens (list and tuple links), then we have the general/glossary term mappings and should keep the specific type dict in parens to keep the intent of the text. On the other hand, if the glossary term for dictionaries is a better explanation than the dict type/function doc, and more specific than the term for mappings, the changed link could be an improvement.

Co-authored-by: Éric <merwok@netwok.org>
@willingcwillingc added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsOct 30, 2024
@willingcwillingc merged commit4f82621 intopython:mainOct 30, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks@furkanonder for the PR, and@willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@bedevere-app
Copy link

GH-126197 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelOct 30, 2024
@bedevere-app
Copy link

GH-126198 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelOct 30, 2024
@merwok
Copy link
Member

The commit message was not trimmed, and github for some unfathomable reason defaults to concatenating the messages of all commits in the PR.

I use a browser extension Refined Github to avoid this, and now there is also a repo setting to change the default merge commit message: I don’t have the time to start a discussion on the forums, but I’m leaving the idea here for someone.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@vadmiumvadmiumvadmium left review comments

@Eclips4Eclips4Eclips4 left review comments

@merwokmerwokmerwok approved these changes

@willingcwillingcwillingc approved these changes

@terryjreedyterryjreedyAwaiting requested review from terryjreedy

@CAM-GerlachCAM-GerlachAwaiting requested review from CAM-Gerlach

+2 more reviewers

@blaisepblaisepblaisep left review comments

@Jacob-FlasheyeJacob-FlasheyeJacob-Flasheye left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@terryjreedyterryjreedy

Labels

3.14bugs and security fixesdocsDocumentation in the Doc dirtestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@furkanonder@terryjreedy@bedevere-bot@merwok@blaisep@JelleZijlstra@vadmium@willingc@CAM-Gerlach@Eclips4@Jacob-Flasheye
[8]ページ先頭
©2009-2025 Movatter.jp