Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-87092: move CFG related code from compile.c to flowgraph.c#103021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 15 commits intopython:mainfromiritkatriel:cfg.c
Mar 31, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedMar 24, 2023•
edited by bedevere-bot
Loading

@iritkatrieliritkatriel requested a review froma team as acode ownerMarch 25, 2023 18:48
@iritkatrieliritkatriel added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMar 25, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commitabaeeac 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMar 25, 2023
@iritkatrieliritkatriel changed the titlegh-87092: move CFG related code from compile.c to cfg.cgh-87092: move CFG related code from compile.c to cfg_opt.cMar 27, 2023
@iritkatrieliritkatriel changed the titlegh-87092: move CFG related code from compile.c to cfg_opt.cgh-87092: move CFG related code from compile.c to flowgraph.cMar 29, 2023
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A bit of duplicated code, otherwise looks fine.

I don't think_PyOpcode_RelativeJump is needed any more, as all jumps are relative.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

And if you don't make the requested changes, you will be put in the comfy chair!

@iritkatriel
Copy link
MemberAuthor

I don't think_PyOpcode_RelativeJump is needed any more, as all jumps are relative.

I agree, but I'd like to do it in a separate PR because I would need to remove usages and the diff here is large enough.

markshannon reacted with thumbs up emoji

@iritkatriel
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonmarkshannon approved these changes

Assignees
No one assigned
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@iritkatriel@bedevere-bot@markshannon
[8]ページ先頭
©2009-2025 Movatter.jp