Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-101100: Test only Doc/ files in nit-picky mode#103019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 1 commit intopython:mainfromhugovk:docs-nit-picky-fix
Mar 25, 2023

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedMar 24, 2023
edited by bedevere-bot
Loading

Follow on from#102513.

Tofix#102513 (comment).

The problem is that thehttps://github.com/Ana06/get-changed-files action gives an error if there's a filename with a space, for example, a news file such asMisc/NEWS.d/next/Core and Builtins/2023-03-17-12-09-45.gh-issue-100982.Pf_BI6.rst.

The error suggests using another format:

Error: One of your files includes a space. Consider using a different output format or removing spaces from your filenames. Please submit an issue on this action's GitHub repo.

We can get in CSV or JSON format instead:

But that would require some refactoring, as we need totouch the list of files.

The quick fix is to filter for files in theDoc/ directory, to only consider those:

It would of course be good to check the NEWS files, but it's less urgent than fixing the CI and unblocking other PRs!

Demo

hugovk#45 is a PR that modifies aDoc/ file plus aMisc/NEWS.d/next/Core and Builtins/ file, and the "Docs / Docs" CI check fails, as expected.

hugovk#44 is the same but also has this change, and "Docs / Docs" passes.

@AlexWaygood
Copy link
Member

Makes sense as a short-term fix!

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks@hugovk for the quick fix!

@encukou
Copy link
Member

We can get in CSV or JSON format instead

IMO, the best fix would be to avoid spaces in CPython sources, so we can use simpler (though less generally correct) tooling.
Here's the blurb issue for it:python/core-workflow#186

hugovk and CAM-Gerlach reacted with thumbs up emoji

@hugovkhugovk deleted the docs-nit-picky-fix branchMarch 27, 2023 11:32
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull requestMar 27, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull requestApr 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@hugovk@AlexWaygood@encukou@CAM-Gerlach@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp