Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-89240: Limit multiprocessing.Pool to 61 workers on Windows#102920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
aisk wants to merge1 commit intopython:mainfromaisk:limit-pool-size

Conversation

@aisk
Copy link
Contributor

@aiskaisk commentedMar 22, 2023•
edited by bedevere-bot
Loading

@erlend-aaslanderlend-aasland changed the titlegh-89240: limit multiprocessing.Pool to 61 workers on windowsgh-89240: Limit multiprocessing.Pool to 61 workers on WindowsJan 6, 2024
Copy link
Contributor

@hauntsaninjahauntsaninja left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks reasonable to me, compare tohttps://github.com/python/cpython/pull/13132/files. Although that PR complains 63 is the max and the overhead is 2 objects.

@aisk
Copy link
ContributorAuthor

aisk commentedJan 7, 2024

It looks like#107873 can totally resolve the original issue if it has been merged, rather than pointing out the limitations in document and error messages like this PR.
So I think it's better to wait until#107873 is merged and close the current PR, or if it's not, then we can restart the review process.

@zooba
Copy link
Member

My PR is waiting on reviews and/or testing. If a couple of people want to confirm that it works, then we can merge it.

Otherwise, this PR looks fine to me.

@aisk
Copy link
ContributorAuthor

Since#107873 has been merged, this issue can be closed now. Still, thank you to everyone who reviewed this!

@aiskaisk closed thisFeb 25, 2024
@aiskaisk deleted the limit-pool-size branchFebruary 25, 2024 14:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja left review comments

@eryksuneryksunAwaiting requested review from eryksun

@corona10corona10Awaiting requested review from corona10

@zoobazoobaAwaiting requested review from zooba

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aisk@zooba@hauntsaninja@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp