Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-102873: logging.LogRecord docs: improve description of msg parameter#102875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@aminalaee
Copy link
Contributor

@aminalaeeaminalaee commentedMar 21, 2023•
edited by bedevere-bot
Loading

@ghost
Copy link

ghost commentedMar 21, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks! I'll wait a few days before merging in case@vsajip has any objections, though, since he's the primary maintainer forlogging :)

Here's a link directly to the docs preview for this class:https://deploy-preview-102875--python-cpython-preview.netlify.app/library/logging.html#logging.LogRecord

aminalaee reacted with heart emoji
@AlexWaygoodAlexWaygood added needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsMar 21, 2023
@AlexWaygoodAlexWaygood changed the titlegh-102873: Update logging LogRecord argument typesgh-102873: logging.LogRecord docs: improve description of msg parameterMar 21, 2023
@AlexWaygoodAlexWaygood merged commitf2e5a6e intopython:mainMar 24, 2023
@miss-islington
Copy link
Contributor

Thanks@aminalaee for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-103003 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelMar 24, 2023
@bedevere-bot
Copy link

GH-103004 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelMar 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 24, 2023
… parameter (pythonGH-102875)(cherry picked from commitf2e5a6e)Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 24, 2023
… parameter (pythonGH-102875)(cherry picked from commitf2e5a6e)Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington added a commit that referenced this pull requestMar 24, 2023
…eter (GH-102875)(cherry picked from commitf2e5a6e)Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@aminalaeeaminalaee deleted the update-logging-logrecord-argument-types branchMarch 24, 2023 15:08
miss-islington added a commit that referenced this pull requestMar 24, 2023
…eter (GH-102875)(cherry picked from commitf2e5a6e)Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull requestMar 27, 2023
… parameter (python#102875)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
warsaw pushed a commit to warsaw/cpython that referenced this pull requestApr 11, 2023
… parameter (python#102875)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

logging module LogRecord can accept non-str msg but it's not documented

4 participants

@aminalaee@miss-islington@bedevere-bot@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp