Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP#102870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedMar 21, 2023•
edited by bedevere-bot
Loading

@iritkatrieliritkatriel marked this pull request as draftMarch 21, 2023 12:24
@iritkatriel
Copy link
MemberAuthor

There's still a problem with the peepholer. Converting to draft.

@iritkatrieliritkatriel marked this pull request as ready for reviewMarch 21, 2023 14:40
@iritkatriel
Copy link
MemberAuthor

Thanks, I’ll wait for benchmark results before merging.

carljm reacted with thumbs up emoji

@markshannon
Copy link
Member

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would expect this to cause a slowdown, but it seems the slowdown is negligible.

I expect that we will be able to get all that back and more with the optimizations discussed in the issue.

@iritkatrieliritkatriel added interpreter-core(Objects, Python, Grammar, and Parser dirs) 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelsMar 22, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commitb2bf829 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMar 22, 2023
@iritkatriel
Copy link
MemberAuthor

refleak check passed.

@iritkatrieliritkatriel merged commit3468c76 intopython:mainMar 22, 2023
@iritkatrieliritkatriel deleted the remove-JUMP_IF_FALSE_OR_POP branchApril 3, 2023 17:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@carljmcarljmcarljm approved these changes

@markshannonmarkshannonmarkshannon approved these changes

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

Assignees

No one assigned

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP

4 participants

@iritkatriel@markshannon@bedevere-bot@carljm
[8]ページ先頭
©2009-2025 Movatter.jp