Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix typo in code comment#102726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 2 commits intopython:mainfrommartin-martin:patch-1
Mar 15, 2023
Merged

Conversation

@martin-martin
Copy link
Contributor

@martin-martinmartin-martin commentedMar 15, 2023•
edited
Loading

I just came across a tiny typo while doing research for an article and thought I'd note it via a PR in case it's considered worth updating. :)

Thanks for all your work!

@ghost
Copy link

ghost commentedMar 15, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-botbedevere-bot added the testsTests in the Lib/test dir labelMar 15, 2023
@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@martin-martin
Copy link
ContributorAuthor

Oh, I thought that a rebase would be a good idea in this situation, as there were some other merged changes before the checks here were complete.

But it looks like a test is failing now? I'm not sure why this would happen considering I rebased onmain and the only change is a typo fix in a code comment.

Apologies, I didn't mean to take up too much of anyones' time with this 😬

@AlexWaygood
Copy link
Member

The failing test will be fixed by#102735; after that's merged, we can mergemain into your branch here, and then the test will pass here and we can merge this in :)

martin-martin reacted with thumbs up emojimartin-martin reacted with hooray emoji

@martin-martin
Copy link
ContributorAuthor

Thank you@AlexWaygood :)

AlexWaygood reacted with thumbs up emoji

@AlexWaygoodAlexWaygood merged commit00d1ef7 intopython:mainMar 15, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull requestMar 27, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull requestApr 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@iritkatrieliritkatrielAwaiting requested review from iritkatriel

Assignees

No one assigned

Labels

skip issueskip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martin-martin@bedevere-bot@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp