I was under the impression that we should not use exception notes internally. I'll try to find a link to the previous discussion (between Victor and Irit, IIRC); it may be relevant to this change.

I was under the impression that we should not use exception notes internally. I'll try to find a link to the previous discussion (between Victor and Irit, IIRC); it may be relevant to this change.

There is no general ban on using the notes in the interpreter. The discussion you are referring to was about splitting the message into a "core error message" as arg and "explanation" on the note, so that IDEs can toggle the explanation on and off. The objection was to introduce assumptions about what is in the note, and how IDEs should handle it. There is also a general guideline that information which is known at the time the exception object is constructed does not belong on the note. Technically of course you can put it on the note, but that was not their intended use.

This PR addresses the classic use case forPEP-678: we have an exception that we did not construct, and we want to enrich it with additional information which was not available at the time that the exception was constructed.

Yeah, that discussion sounds familiar. Do you happen to have a link to it?

Yeah, that discussion sounds familiar. Do you happen to have a link to it?

I don't, sorry.

FYI@Zac-HD

Yeah, that discussion sounds familiar. Do you happen to have a link to it?

I don't, sorry.

There was some previous discussion in:

• gh-95778: Use a note for the max digits error message #96878
• Use Python 3.11 exception notes (PEP 678) to provide hints on errors #96958

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit8f0f2be 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit140770f 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

PS. Shouldn'tPyErr_NormalizeException also add the same note?

PS. Shouldn'tPyErr_NormalizeException also add the same note?

We could, but it's deprecated so I'm not sure how much it matters now.

Fair