Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-102541: Hide traceback in help prompt#102614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
corona10 merged 2 commits intopython:mainfromEclips4:issue-102541
Jun 14, 2023

Conversation

@Eclips4
Copy link
Member

@Eclips4Eclips4 commentedMar 11, 2023•
edited by bedevere-bot
Loading

Addis_cli param todoc function (by default, set toFalse).
Whenis_cli arg isTrue, we raise a ImportError, otherwise, just show amissing_pattern.
Although, add a variablemissing_pattern, which now is used byresolve anddoc functions.
This PR absolutely compatible with#89130.
I like tests, but i think, that case shouldn't be tested.
If core-devs approve this, it should be merged to3.11 and3.12 branches.
On 3.10 this works fine.

arhadthedev reacted with thumbs up emoji
@Eclips4
Copy link
MemberAuthor

Could someone review it? =)

@Eclips4
Copy link
MemberAuthor

@sobolevn
Can you review it?

@arhadthedevarhadthedev added the stdlibStandard Library Python modules in the Lib/ directory labelMar 22, 2023
@Eclips4
Copy link
MemberAuthor

Can someone from core developers review it?

@terryjreedyterryjreedy requested a review fromambvJune 12, 2023 17:50
@terryjreedyterryjreedy added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsJun 12, 2023
@terryjreedy
Copy link
Member

terryjreedy commentedJun 12, 2023•
edited
Loading

The most appropriate coredev reviewer would be whoever merged the PR that caused the regression. That would have to be a feature addition after 3.10.0b1, May 2021 (and hence not backported to 3.10) and before 3.11.0 in Oct 2022.#98450 fixed a related bug --help('invalid query') raising with similar result. This caught the exception in a different place (line 2005) and remains fixed.

help need more automated tests.

Eclips4 reacted with thumbs up emoji

@corona10
Copy link
Member

I will take a look at this PR tonight (UTC+9)

Eclips4 reacted with thumbs up emoji

Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with nit comment.
Writing test code will be great, but I know this case is very hard to write. :)

@corona10
Copy link
Member

Please rebase the PR.

@corona10corona10 merged commitba516e7 intopython:mainJun 14, 2023
@miss-islington
Copy link
Contributor

Thanks@Eclips4 for the PR, and@corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@Eclips4 and@corona10, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker ba516e70c6d156dc59dede35b6fc3db0151780a5 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 14, 2023
(cherry picked from commitba516e7)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-bot
Copy link

GH-105778 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 14, 2023
corona10 pushed a commit that referenced this pull requestJun 15, 2023
gh-102541: Hide traceback in help prompt (gh-102614)(cherry picked from commitba516e7)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-bot
Copy link

GH-105830 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJun 15, 2023
corona10 pushed a commit to corona10/cpython that referenced this pull requestJun 15, 2023
(cherry picked from commitba516e7)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
corona10 added a commit that referenced this pull requestJun 15, 2023
(cherry picked from commitba516e7)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@Eclips4Eclips4 deleted the issue-102541 branchJune 19, 2023 19:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes

@ambvambvAwaiting requested review from ambv

+1 more reviewer

@chgnrdvchgnrdvchgnrdv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@corona10corona10

Labels

stdlibStandard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Eclips4@terryjreedy@corona10@miss-islington@bedevere-bot@chgnrdv@arhadthedev
[8]ページ先頭
©2009-2025 Movatter.jp