Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-102507 Remove invisible pagebreak characters#102531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 6 commits intopython:mainfromJosephSBoyle:fix-issue-102507
Mar 8, 2023

Conversation

JosephSBoyle
Copy link
Contributor

@JosephSBoyleJosephSBoyle commentedMar 8, 2023•
edited by bedevere-bot
Loading

Removes invisible pagebreak chars from the repository.

These chars are not visible in the gh-diff, but code editors should display them. For instance VSCode displays it as this strange red box:

image

@JosephSBoyleJosephSBoyle marked this pull request as ready for reviewMarch 8, 2023 11:43
@AlexWaygood
Copy link
Member

FYI we much prefer merge commits over rebases in the CPython repo, where possible. Rebases (well, force-pushes in general) interact quite badly with the GitHub UI, making it quite hard to see what changed in between commits and making incremental review quite difficult. Everything's squash-merged in the end anyway, so a messy git history on a PR is usually nothing to worry about!

@JosephSBoyle
Copy link
ContributorAuthor

FYI we much prefer merge commits over rebases in the CPython repo, where possible. Rebases (well, force-pushes in general) interact quite badly with the GitHub UI, making it quite hard to see what changed in between commits and making incremental review quite difficult. Everything's squash-merged in the end anyway, so a messy git history on a PR is usually nothing to worry about!

Aha, that makes sense. Thanks for the headsup@AlexWaygood 🙇

AlexWaygood reacted with heart emoji

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@sobolevn
Copy link
Member

I once saw a similar PR that was rejected :(
But, I cannot remember by who and why

@AlexWaygood
Copy link
Member

AlexWaygood commentedMar 8, 2023•
edited
Loading

I once saw a similar PR that was rejected :( But, I cannot remember by who and why

It was rejected because Guido said we should do it all at once if we wanted to do it, rather than doing it just in one file. And that's exactly what@JosephSBoyle has done here :)

sobolevn and JosephSBoyle reacted with thumbs up emoji

@AlexWaygoodAlexWaygood merged commitb097925 intopython:mainMar 8, 2023
carljm added a commit to carljm/cpython that referenced this pull requestMar 8, 2023
* main:pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)pythongh-102507 Remove invisible pagebreak characters (python#102531)pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)  Remove or update bitbucket links (pythonGH-101963)pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)  Fix style in argparse.rst (python#101733)  Post 3.12.0a6  fix typo in async generator code field name `ag_code` (python#102448)  Python 3.12.0a6
@hugovkhugovk added the needs backport to 3.11only security fixes labelAug 22, 2023
@miss-islington
Copy link
Contributor

Thanks@JosephSBoyle for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 22, 2023
(cherry picked from commitb097925)Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com>Co-authored-by: AlexWaygood <alex.waygood@gmail.com>
@bedevere-bot
Copy link

GH-108266 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelAug 22, 2023
AlexWaygood added a commit that referenced this pull requestAug 22, 2023
…108266)gh-102507 Remove invisible pagebreak characters (GH-102531)(cherry picked from commitb097925)Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com>Co-authored-by: AlexWaygood <alex.waygood@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove invisible pagebreak chars from the standard library
6 participants
@JosephSBoyle@AlexWaygood@sobolevn@miss-islington@bedevere-bot@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp