Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-102837: few coverage nitpicks for the math module#102523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hauntsaninja merged 20 commits intopython:mainfromskirpichev:math-cov
Sep 3, 2023

Conversation

@skirpichev
Copy link
Contributor

@skirpichevskirpichev commentedMar 8, 2023•
edited
Loading

  • input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168), ceil(L1165), floor(L1236,L1239) and dist(L2587,L2588,L2628).
  • drop inaccessible "if" branch (L3518) in perm_comb_small()
  • improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497), ditto fmod(L2378)
  • rewrite modf to fix inaccessible case(L2229), ditto for pow(L2988)

(all line numbers are wrt the main branch at5e6661b)

@skirpichev
Copy link
ContributorAuthor

skirpichev commentedMar 8, 2023•
edited
Loading

Note, c.f.#102067 for the cmath module - there are still some uncovered lines/branches.

@skirpichev
Copy link
ContributorAuthor

@AlexWaygood, do you think this requires an issue?

@AlexWaygood
Copy link
Member

AlexWaygood commentedMar 8, 2023•
edited
Loading

@AlexWaygood, do you think this requires an issue?

Our policy is generally to require issues for all changes, unless they'reextremely trivial (such as typo fixes).

(If the maintainers of themath module decide this doesn't need an issue then that's obviously fine, but I'm not amath module maintainer, so I don't want to decide that for them :)

@skirpichev
Copy link
ContributorAuthor

skirpichev commentedMar 8, 2023 via email

On Wed, Mar 08, 2023 at 06:21:43AM -0800, Alex Waygood wrote: Our policy is generally to require issues for all changes, unless they're extremely trivial (such as typo fixes).
Ok. I thought this is trivial:)

@mdickinsonmdickinson self-requested a reviewMarch 8, 2023 17:40
- input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071),  hypot(L2682), log(L2307), ldexp(L2168) and dist(L2587,L2588,L2628).- rewrite math_floor like math_ceil (cover L1239)- drop inaccessible "if" branch (L3518) in perm_comb_small()- improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497),  ditto fmod(L2378)- rewrite modf to fix inaccessible case(L2229), ditto for pow(L2988)(all line numbers wrt the main branch at 5e6661b)
@skirpichevskirpichev changed the titleFew coverage nitpicks for the math modulegh-102837: few coverage nitpicks for the math moduleMar 20, 2023
Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@skirpichev
Copy link
ContributorAuthor

Last commit will cover rest of math_floor()/ceil().

hauntsaninja reacted with thumbs up emoji

Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the follow ups! :-)

@skirpichev
Copy link
ContributorAuthor

Next pr:#110000

skirpichev added a commit to skirpichev/cpython that referenced this pull requestOct 6, 2023
encukou pushed a commit to encukou/cpython that referenced this pull requestNov 13, 2023
pythonGH-102523)(Only the test changes frompythonGH-102523 are cherry-picked)- input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168), ceil(L1165), floor(L1236,L1239) and dist(L2587,L2588,L2628).- improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497), ditto fmod(L2378)(all line numbers are wrt the main branch at5e6661b)
@bedevere-app
Copy link

GH-112030 is a backport of this pull request to the3.12 branch.

encukou added a commit that referenced this pull requestNov 13, 2023
… (GH-112030)*gh-102837: improve test coverage for math module (GH-102523)(Only the test changes fromGH-102523 are cherry-picked)- input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168), ceil(L1165), floor(L1236,L1239) and dist(L2587,L2588,L2628).- improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497), ditto fmod(L2378)(all line numbers are wrt the main branch at5e6661b)*gh-102837: more tests for the math module (GH-111930)Add tests to improve coverage:* fsum: L1369, L1379, L1383, L1412* trunc: L2081* log: L2267* dist: L2577, L2579* hypot: L2632* sumprod: L2744, L2754, L2774, L2778, L2781, L2785, L2831, L2835, L2838* pow: L2982* prod: L3294, L3308, L3318-3330// line numbers wrt to9dc4fb8(cherry picked from commitc61de45)---------Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
encukou added a commit that referenced this pull requestNov 16, 2023
… (GH-112030) (GH-112041)[3.12]gh-102837: more tests for the math module (GH-111930)(GH-102523) (GH-112030)*gh-102837: improve test coverage for math module (GH-102523)(Only the test changes fromGH-102523 are cherry-picked)- input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168), ceil(L1165), floor(L1236,L1239) and dist(L2587,L2588,L2628).- improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497), ditto fmod(L2378)(all line numbers are wrt the main branch at5e6661b)*gh-102837: more tests for the math module (GH-111930)Add tests to improve coverage:* fsum: L1369, L1379, L1383, L1412* trunc: L2081* log: L2267* dist: L2577, L2579* hypot: L2632* (not cherry-picked for 3.11: sumprod)* pow: L2982* prod: L3294, L3308, L3318-3330// line numbers wrt to9dc4fb8(cherry picked from commitc61de45)---------Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>(cherry picked from commitc6aea46)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@hauntsaninjahauntsaninjahauntsaninja approved these changes

@mdickinsonmdickinsonAwaiting requested review from mdickinson

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skirpichev@AlexWaygood@serhiy-storchaka@hauntsaninja@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp