Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-102500: Implement PEP 688#102521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 51 commits intopython:mainfromJelleZijlstra:pep688v2
May 4, 2023
Merged

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedMar 8, 2023•
edited
Loading

This PR implements only the code changes for the PEP; documentation will be added separately.

Example:

>>> memoryview(b"x", flags=inspect.BufferFlags.WRITABLE)Traceback (most recent call last):  File "<stdin>", line 1, in <module>BufferError: Object is not writable.>>> memoryview(b"x", flags=inspect.BufferFlags.SIMPLE)<memory at 0x103391640>

Copy link
Member

@sobolevnsobolevn left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am always happy whentyping-related work is used for better APIs! Thank you 🎉

@JelleZijlstraJelleZijlstra requested a review froma team as acode ownerMarch 10, 2023 04:58
@kumaraditya303
Copy link
Contributor

@JelleZijlstra I pushed some fixes directly, hope you don't mind it. See my review comments, especially the one for typeobject.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@JelleZijlstra
Copy link
MemberAuthor

Thanks Kumar for the review and fixes!

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hauntsaninja,@kumaraditya303: please review the changes made to this pull request.

@JelleZijlstra
Copy link
MemberAuthor

Seems like I need to run regen-all, doing that.

Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@JelleZijlstraJelleZijlstra merged commit04f6733 intopython:mainMay 4, 2023
@JelleZijlstraJelleZijlstra deleted the pep688v2 branchMay 4, 2023 14:59
carljm added a commit to carljm/cpython that referenced this pull requestMay 5, 2023
* main: (61 commits)pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)pythongh-64658: Expand Argument Clinic return converter docs (python#104175)pythonGH-103092: port `_asyncio` freelist to module state (python#104196)pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)pythongh-104190: fix ubsan crash (python#104191)pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)pythongh-68968: Correcting message display issue with assertEqual (python#103937)pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)pythongh-91896: Deprecate collections.abc.ByteString (python#102096)pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)pythongh-102500: Document PEP 688 (python#102571)pythongh-102500: Implement PEP 688 (python#102521)pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)  ...
@JelleZijlstraJelleZijlstra restored the pep688v2 branchSeptember 10, 2024 23:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently left review comments

@sobolevnsobolevnsobolevn left review comments

@TeamSpen210TeamSpen210TeamSpen210 left review comments

@sunmy2019sunmy2019sunmy2019 left review comments

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@encukouencukouAwaiting requested review from encukou

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@hauntsaninjahauntsaninjaAwaiting requested review from hauntsaninja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

10 participants
@JelleZijlstra@rhettinger@arhadthedev@ericsnowcurrently@bedevere-bot@kumaraditya303@sobolevn@TeamSpen210@hauntsaninja@sunmy2019
[8]ページ先頭
©2009-2025 Movatter.jp