Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-102153: Start stripping C0 control and space chars inurlsplit#102508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+119 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xiaoge1001 commentedMar 8, 2023
It's great. it handle some bad input URLs and make urlsplit more robust. |
xiaoge1001 commentedMar 8, 2023
This PR moves us in the direction I'd like to see the APIs go. I'm not sure it could ever be backported as a security fix for the long list of analysis reasons I just posted over in the Issue, but it might make sense in 3.12. I believe there's still an open question of trailing spaces on paths potentially carrying meaning in some (presumably not-HTTP) scenarios (see the Issue analysis). So stripping all of the C0 characters early on might not be the right approach. But they should be stripped from most places. Lets keep this PR around as a likely option. (I'll still put a do-not-submit tag on it for now, just as an indicator that we're not ready to accept ityet). |
xiaoge1001 commentedMar 25, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Is it planned to merge the current patch to python3.12? I don't find there's been any discussion recently. |
Many existing applications rely (for better or worse) on the trailing spacesbeing preserved by this API. So this moves more conservative and keeps those.The issue this change is addressing is triggered by leading spaces.One example library relyong on behavior: Django's URL validator library (atleast in Django 3.2 and earlier; I have not checked later versions). Iftrailing spaces are stripped, its logic that involves urllib.parse for one logicpath within its checks can fail to reject some URLs as invalid.
Also be explicit about specifying utf-8 on encode and decode.
Results from internal testing across a huge body of code (including test suites of many open source libraries and applications): Stripping the C0 characters from the left hand side doesn't appear to cause any problems. Stripping them from the right hand side of the URL does, as existing code calling urllib.parse such as i've updated the PR to use lstrip on the url. |
I'm a lot more confident that we could actually backport this as a security bug fix without breaking the world now. As for documentation to be added to warn users of these APIs, I'm not quite sure how to word that and what to convey yet. I've opened up as a discussion inhttps://discuss.python.org/t/how-to-word-a-warning-about-security-uses-in-urllib-parse-docs/26399. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The first beta is expected to be released on Monday and it'd be very nice to have this in the release.
Uh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/Security/2023-03-07-20-59-17.gh-issue-102153.14CLSZ.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com>
remove "trailing"
I intend to get this in before the next releases are cut. The last bit is for me to add some appropriate text to the urllib.parse documentation recommending that people verify that the outputs from the API makes sense before trusting any of them. |
We have one week to the first beta. Is there anything I can help you with? |
The added section describing the situation is longer than I might want,but being more brief just leaves open questions.This is a lighter worded version of my original text proposed inhttps://discuss.python.org/t/how-to-word-a-warning-about-security-uses-in-urllib-parse-docs/26399
ambv pushed a commit that referenced this pull requestJun 5, 2023
…lit` (GH-102508) (GH-104575) (GH-104592) (#104593) (#104895)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).I simplified the docs by eliding the state of the world explanatoryparagraph in this security release only backport. (people will seethat in the mainline /3/ docs)(cherry picked from commitd7f8a5f)(cherry picked from commit2f630e1)(cherry picked from commit610cc0a)(cherry picked from commitf48a96a)Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
encukou added a commit to encukou/cpython that referenced this pull requestJun 7, 2023
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12
carlosroman added a commit to DataDog/cpython that referenced this pull requestJun 22, 2023
* Post 3.8.16* [3.8] Update copyright years to 2023. (pythongh-100852)* [3.8] Update copyright years to 2023. (pythongh-100848).(cherry picked from commit11f9932)Co-authored-by: Benjamin Peterson <benjamin@python.org>* Update additional copyright years to 2023.Co-authored-by: Ned Deily <nad@python.org>* [3.8] Update copyright year in README (pythonGH-100863) (pythonGH-100867)(cherry picked from commit30a6cc4)Co-authored-by: Ned Deily <nad@python.org>Co-authored-by: HARSHA VARDHAN <75431678+Thunder-007@users.noreply.github.com>* [3.8] CorrectCVE-2020-10735 documentation (pythonGH-100306) (python#100698)(cherry picked from commit1cf3d78)(cherry picked from commit88fe8d7)Co-authored-by: Jeremy Paige <ucodery@gmail.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>* [3.8] Bump Azure Pipelines to ubuntu-22.04 (pythonGH-101089) (python#101215)(cherry picked from commitc22a55c)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>* [3.8]pythongh-100180: Update Windows installer to OpenSSL 1.1.1s (pythonGH-100903) (python#101258)*pythongh-101422: (docs) TarFile default errorlevel argument is 1, not 0 (pythonGH-101424)(cherry picked from commitea23271)Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>* [3.8]pythongh-95778: add doc missing in some places (pythonGH-100627) (python#101630)(cherry picked from commit4652182)* [3.8]pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286) (python#101710)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>Co-authored-by: Steve Dower <steve.dower@microsoft.com>* [3.8]pythongh-101981: Fix Ubuntu SSL tests with OpenSSL (3.1.0-beta1) CI i… (python#102095)[3.8]pythongh-101981: Fix Ubuntu SSL tests with OpenSSL (3.1.0-beta1) CI issue (pythongh-102079)* [3.8]pythonGH-102306 Avoid GHA CI macOS test_posix failure by using the appropriate macOS SDK (pythonGH-102307)[3.8] Avoid GHA CI macOS test_posix failure by using the appropriate macOS SDK.* [3.8]pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727) (pythonGH-101752)FixesCVE-2023-0286 (High) and a couple of Medium security issues.https://www.openssl.org/news/secadv/20230207.txtCo-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Ned Deily <nad@python.org>* [3.8]pythongh-102627: Replace address pointing toward malicious web page (pythonGH-102630) (pythonGH-102667)(cherry picked from commit61479d4)Co-authored-by: Blind4Basics <32236948+Blind4Basics@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>* [3.8]pythongh-101997: Update bundled pip version to 23.0.1 (pythonGH-101998). (python#102244)(cherry picked from commit89d9ff0)* [3.8]pythongh-102950: Implement PEP 706 – Filter for tarfile.extractall (pythonGH-102953) (python#104548)Backport ofc8c3956* [3.8]pythongh-99889: Fix directory traversal security flaw in uu.decode() (pythonGH-104096) (python#104332)(cherry picked from commit0aeda29)Co-authored-by: Sam Carroll <70000253+samcarroll42@users.noreply.github.com>* [3.8]pythongh-104049: do not expose on-disk location from SimpleHTTPRequestHandler (pythonGH-104067) (python#104121)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>* [3.8]pythongh-103935: Use `io.open_code()` when executing code in trace and profile modules (pythonGH-103947) (python#103954)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>* [3.8]pythongh-68966: fix versionchanged in docs (pythonGH-105299)* [3.8] Update GitHub CI workflow for macOS. (pythonGH-105302)* [3.8]pythongh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (pythonGH-105185) (python#105222)(cherry picked from commitee26ca1)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>* [3.8]pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508) (pythonGH-104575) (pythonGH-104592) (python#104593) (python#104895)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).I simplified the docs by eliding the state of the world explanatoryparagraph in this security release only backport. (people will seethat in the mainline /3/ docs)(cherry picked from commitd7f8a5f)(cherry picked from commit2f630e1)(cherry picked from commit610cc0a)(cherry picked from commitf48a96a)Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>* [3.8]pythongh-103142: Upgrade binary builds and CI to OpenSSL 1.1.1u (pythonGH-105174) (pythonGH-105200) (pythonGH-105205) (python#105370)Upgrade builds to OpenSSL 1.1.1u.Also updates _ssl_data_111.h from OpenSSL 1.1.1u, _ssl_data_300.h from 3.0.9.Manual edits to the _ssl_data_300.h file prevent it from removing anyexisting definitions in case those exist in some peoples builds and wereimportant (avoiding regressions during backporting).(cherry picked from commitede89af)(cherry picked from commite15de14)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Ned Deily <nad@python.org>* Python 3.8.17* Post 3.8.17* Updated CI to build 3.8.17---------Co-authored-by: Łukasz Langa <lukasz@langa.pl>Co-authored-by: Benjamin Peterson <benjamin@python.org>Co-authored-by: Ned Deily <nad@python.org>Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: HARSHA VARDHAN <75431678+Thunder-007@users.noreply.github.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jeremy Paige <ucodery@gmail.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Steve Dower <steve.dower@python.org>Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>Co-authored-by: Éric <earaujo@caravan.coop>Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>Co-authored-by: Steve Dower <steve.dower@microsoft.com>Co-authored-by: Dong-hee Na <donghee.na@python.org>Co-authored-by: Blind4Basics <32236948+Blind4Basics@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Sam Carroll <70000253+samcarroll42@users.noreply.github.com>Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>Co-authored-by: stratakis <cstratak@redhat.com>Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
hroncok pushed a commit to fedora-python/cpython that referenced this pull requestOct 6, 2023
00399 #*pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported to Python 2 from Python 3.12.Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>Co-authored-by: Lumir Balhar <lbalhar@redhat.com>
hroncok pushed a commit to fedora-python/cpython that referenced this pull requestNov 28, 2023
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull requestFeb 22, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull requestFeb 27, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
hroncok pushed a commit to fedora-python/cpython that referenced this pull requestMar 7, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 11, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 11, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 20, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 20, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 20, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 20, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 25, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
hroncok pushed a commit to fedora-python/cpython that referenced this pull requestMar 26, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull requestApr 2, 2024
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
hrnciar pushed a commit to fedora-python/cpython that referenced this pull requestApr 23, 2025
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
hroncok pushed a commit to fedora-python/cpython that referenced this pull requestJul 4, 2025
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
frenzymadness pushed a commit to fedora-python/cpython that referenced this pull requestAug 12, 2025
pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).Backported from Python 3.12(cherry picked from commitf48a96a)Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
xmo-odoo added a commit to odoo-dev/odoo that referenced this pull requestOct 14, 2025
This is a private variable of the stdlib, it was added in Python3.12 (python/cpython#102508) and only backported to3.11.4 (cpython/python#104575) and 3.10.12 (cpython/python#104592) sois not necessarily available in versions of 3.10 and 3.11 clientsmight be running. So embed the content into the file directly to avoiddepending on the stdlib. Not to mention the concept of C0 is notexactly novel or mutable.Also inline it in its sole use, there's no reason to have multiplestring literals and a runtime concatenation.Fixesodoo#230990
robodoo pushed a commit to odoo/odoo that referenced this pull requestOct 14, 2025
This is a private variable of the stdlib, it was added in Python 3.12 (python/cpython#102508) and only backported to 3.11.4 (python/cpython#104575) and 3.10.12 (python/cpython#104592) so is not necessarily available in versions of 3.10 and 3.11 clients might be running. So embed the content into the file directly to avoid depending on the stdlib. Not to mention the concept of C0 is not exactly novel or mutable.Also inline it in its sole use, there's no reason to have multiple string literals and a runtime concatenation.Fixes#230990closes#231371Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull requestOct 14, 2025
This is a private variable of the stdlib, it was added in Python3.12 (python/cpython#102508) and only backported to3.11.4 (cpython/python#104575) and 3.10.12 (cpython/python#104592) sois not necessarily available in versions of 3.10 and 3.11 clientsmight be running. So embed the content into the file directly to avoiddepending on the stdlib. Not to mention the concept of C0 is notexactly novel or mutable.Also inline it in its sole use, there's no reason to have multiplestring literals and a runtime concatenation.Fixesodoo#230990X-original-commit:0374281
robodoo pushed a commit to odoo/odoo that referenced this pull requestOct 14, 2025
This is a private variable of the stdlib, it was added in Python 3.12 (python/cpython#102508) and only backported to 3.11.4 (python/cpython#104575) and 3.10.12 (python/cpython#104592) so is not necessarily available in versions of 3.10 and 3.11 clients might be running. So embed the content into the file directly to avoid depending on the stdlib. Not to mention the concept of C0 is not exactly novel or mutable.Also inline it in its sole use, there's no reason to have multiple string literals and a runtime concatenation.Fixes#230990closes#231428Forward-port-of:#231371Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
stdlibStandard Library Python modules in the Lib/ directory type-bugAn unexpected behavior, bug, or error type-securityA security issue
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
urllib.parse.urlsplithas already been respecting the WHATWG spec a bit#25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input"rule in response toCVE-2023-24329.