Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-81057: Vendor a Subset of distutils for the c-analyzer Tool#102505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedMar 7, 2023•
edited by bedevere-bot
Loading

distutils was removed in November. However, the c-analyzer relies on it. To solve that here, we vendor the parts the tool needs so it can be run against 3.12+. (Also seegh-92584.)

@ericsnowcurrently
Copy link
MemberAuthor

Note that none of the Windows-related support actually implements the preprocessor code the c-analyzer needs. Here's what that might look like, though:elijahr/python-autopxd2#40.

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note,distutils is also used inpeg_generator:

importdistutils.log
fromdistutils.coreimportDistribution,Extension
fromdistutils.tests.supportimportfixup_build_ext# type: ignore
fromdistutils.ccompilerimportnew_compiler
fromdistutils.dep_utilimportnewer_group
fromdistutils.sysconfigimportcustomize_compiler

Will it be convinient to use the single vendored version for both of them?

@ericsnowcurrently
Copy link
MemberAuthor

Thanks for pointing this out. I'll take a look.

@AlexWaygood
Copy link
Member

See these two previous issues that were opened on this topic:

ericsnowcurrently reacted with thumbs up emoji

@ericsnowcurrently
Copy link
MemberAuthor

(See#92584 (comment).)

I'm fine with sharing a solution with peg_generator (e.g. a common vendored distutils). In the meantime, I'd like to land this PR. We can remove this vendored distutils when there's a shared solution.

AlexWaygood reacted with thumbs up emoji

@ericsnowcurrentlyericsnowcurrently merged commitca066bd intopython:mainMar 9, 2023
@ericsnowcurrentlyericsnowcurrently deleted the c-analyzer-vendor-distutils branchMarch 9, 2023 16:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently@AlexWaygood@sobolevn@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp