Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-80486: Fix handling of NTFS alternate data streams in pathlib#102454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 12 commits intopython:mainfrombarneygale:gh-80486-ntfs-alt-stream-path
Mar 10, 2023

Conversation

barneygale
Copy link
Contributor

@barneygalebarneygale commentedMar 6, 2023•
edited by bedevere-bot
Loading

This fixes round-tripping of Windows paths like./c:a in pathlib.

Previously, pathlib removed the./ prefix when generating a string representation of such paths. This changed the meaning, from a file in the current directory called "c" with an NTFS alternate data stream, to a relative path on the "c:" drive.

Most of the patch by@kmaork. I brought it up-to-date.

@barneygalebarneygale changed the titleGH-80486: Fix handling of NTFS alternate data streamsGH-80486: Fix handling of NTFS alternate data streams in pathlibMar 6, 2023
@barneygale
Copy link
ContributorAuthor

This won't backport as it relies on a number of internal changes in 3.12 only.

@zooba
Copy link
Member

Are we going to wait for#102511 to be implemented? Or leave a note in that one to update this use when it's done?

As this issue is about correctness and the other is about performance, I'd prefer not to wait.

@barneygale
Copy link
ContributorAuthor

Personally I'd rather not wait! :)

@zooba
Copy link
Member

Feel free to merge (and backport as appropriate), then!

@barneygale
Copy link
ContributorAuthor

I'm not a core dev so I don't have any merge permissions I don't think! 😅

@zooba
Copy link
Member

zooba commentedMar 10, 2023•
edited
Loading

Oh aren't you? We should probably fix that 😉 (though I'm literally about to step away for the weekend, so next week)

barneygale reacted with heart emoji

@barneygale
Copy link
ContributorAuthor

(and unfortunately this won't backport due to other changes in 3.12 being required)

zooba reacted with thumbs up emoji

@zoobazooba merged commit90f1d77 intopython:mainMar 10, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull requestMar 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@eryksuneryksuneryksun left review comments

@zoobazoobazooba approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@barneygale@zooba@eryksun@bedevere-bot@kmaork
[8]ページ先頭
©2009-2025 Movatter.jp