NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

fix typo in async generator code field name`ag_code`#102448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kumaraditya303 merged 1 commit intopython:mainfromkumaraditya303:typo

Mar 8, 2023

Merged

fix typo in async generator code field name`ag_code`#102448

kumaraditya303 merged 1 commit intopython:mainfromkumaraditya303:typo

Mar 8, 2023

Conversation

Copy link

Contributor

kumaraditya303 commentedMar 5, 2023

No description provided.

fix typo

b668f75

kumaraditya303 requested a review frommarkshannon as acode owner

March 5, 2023 17:32

bedevere-bot added the awaiting core review label

Mar 5, 2023

kumaraditya303 requested a review fromAlexWaygood

March 5, 2023 17:32

kumaraditya303 added skip issue skip news needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Mar 5, 2023

Copy link

Member

AlexWaygood commentedMar 5, 2023•
edited
Loading

Not too familiar with this code and not very confident with C, so I'll leave this one to you and Mark :)

(The changelooks correct, but it's weird to me that this wasn't flagged by our tests -- worth a test, maybe? But as I say, I'm probably not the right reviewer here :)

AlexWaygood removed their request for review

March 5, 2023 17:55

Copy link

ContributorAuthor

kumaraditya303 commentedMar 6, 2023

Not too familiar with this code and not very confident with C, so I'll leave this one to you and Mark :)

I didn't mean to request review, might have mis-clicked while applying labels or got distracted and didn't see. Sorry.

kumaraditya303 merged commite499680 intopython:main

Mar 8, 2023

Copy link

Contributor

miss-islington commentedMar 8, 2023

Thanks@kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting core review label

Mar 8, 2023

kumaraditya303 deleted the typo branch

March 8, 2023 03:39

Copy link

Contributor

miss-islington commentedMar 8, 2023

Sorry,@kumaraditya303, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker e499680100a9d4fa4b673cbcfebc32212b4f848a 3.11

miss-islington assignedkumaraditya303

Mar 8, 2023

Copy link

Contributor

miss-islington commentedMar 8, 2023

Sorry@kumaraditya303, I had trouble checking out the3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker e499680100a9d4fa4b673cbcfebc32212b4f848a 3.10

carljm added a commit to carljm/cpython that referenced this pull request

Mar 8, 2023

Merge branch 'main' into inlinecomp2

06db319

* main:pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)pythongh-102507 Remove invisible pagebreak characters (python#102531)pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)  Remove or update bitbucket links (pythonGH-101963)pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)  Fix style in argparse.rst (python#101733)  Post 3.12.0a6  fix typo in async generator code field name `ag_code` (python#102448)  Python 3.12.0a6