Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
bpo-25416: add aliases for cp874 and mac_cyrillic encodings#10237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Neither cp874 nor mac_cyrillic are mentioned onbpo-18624.
| @@ -439,6 +443,7 @@ | |||
| # mac_cyrillic codec | |||
| 'maccyrillic' : 'mac_cyrillic', | |||
| 'x_mac_cyrillic' : 'mac_cyrillic', | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why x_mac_cyrillic, but not x_mac_greek etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because the issue was only about cyrillic. I think that we should implement all the aliases but I'm not sure if I should do it in a PR related to a issue that cited only those two. I can implement the others if you think that's ok to do it in this PR
fbidu commentedNov 2, 2018 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading.Please reload this page.
@serhiy-storchaka: |
Hi@serhiy-storchaka I just ran into a discussion about encoding and remembered of this PR. Do you think it still makes sense? Thanks |
This PR is stale because it has been open for 30 days with no activity. |
Uh oh!
There was an error while loading.Please reload this page.
Hi all!
This PR is about issue 25416 that is also closely related with withbpo-18624, both deal with missing aliases in the encondings module.
In this changeset I only tackled the lack of aliases reported on 25416 but I'm still missing tests on it. Reading through 18624, I noted that the file suggested by@bitdancer -
test_encodings.py- is missing. The author of 18624's patch added a test ontest_codecs.pybut that test seems incomplete.I'm considering add a test that checks if all the aliases are implemented and another one that checks if they are mapped to correct encodings. I'd be glad if a core dev could give me a guidance in how to proceed with that.
Thank you!
https://bugs.python.org/issue25416