Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-102251: Updates to test_imp Toward Fixing Some Refleaks#102254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ericsnowcurrently merged 17 commits intopython:mainfromericsnowcurrently:fix-ext-module-refleaksFeb 27, 2023
Merged
gh-102251: Updates to test_imp Toward Fixing Some Refleaks#102254
ericsnowcurrently merged 17 commits intopython:mainfromericsnowcurrently:fix-ext-module-refleaksFeb 27, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
bedevere-bot commentedFeb 25, 2023
🤖 New build scheduled with the buildbot fleet by@ericsnowcurrently for commitf0ce607 🤖 If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again. |
Looks like the leaks in test_list and test_iter were unrelated. (Seegh-102265.) |
carljm added a commit to carljm/cpython that referenced this pull requestFeb 28, 2023
* main: (67 commits)pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308)pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333)pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331)pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309) Migrate to new PSF mailgun account (python#102284)pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193)pythonGH-90744: Fix erroneous doc links in the sys module (python#101319)pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093)pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102) IDLE: Simplify DynOptionsMenu __init__code (python#101371)pythongh-101561: Add typing.override decorator (python#101564)pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843)pythongh-101773: Optimize creation of Fractions in private methods (python#101780)pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254)pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297)pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287)pythongh-101100: Fix sphinx warnings in `types` module (python#102274)pythongh-91038: Change default argument value to `False` instead of `0` (python#31621)pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283) [doc] Improve grammar/fix missing word (pythonGH-102060) ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This includes some cleanup, some tweaks to the existing tests, and a bunch of new test cases. It is all related to fixing the refleaks introduced by096d009. I haven't been able to find the leak yet, but these changes are a consequence of that effort.
The only change here that might have impact outside the tests in question is in imp.py, where I update
imp.load_dynamic()to usespec_from_file_location()instead of creating aModuleSpecdirectly. (See commit0c65700 below.)Also note that I've updated the tests to only skip if we're checking for refleaks (regrtest's
--huntrleaks), whereas ingh-101969 I had skipped the tests entirely. The tests will be useful for some upcoming work and I'd rather the refleaks not hold that up. (It isn't clear how quickly we'll be able to fix the leaking code, though it will certainly be done in the short term.)