Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99108: Followup fix for Modules/Setup#102183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
miss-islington merged 1 commit intopython:mainfrommsprotz:protz_md5_sha1
Feb 23, 2023

Conversation

msprotz
Copy link
Contributor

@msprotzmsprotz commentedFeb 23, 2023•
edited by erlend-aasland
Loading

Copy link
Contributor

@asottileasottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no idea why the cpython suite doesn't fail -- my guess is it doesn't use this file

gpshead reacted with thumbs up emoji
@msprotz
Copy link
ContributorAuthor

thanks -- do you mind adding a skip-news label, too?

@erlend-aasland
Copy link
Contributor

erlend-aasland commentedFeb 23, 2023•
edited
Loading

Can you please fixModules/Setup.stdlib.in also?

@asottile
Copy link
Contributor

Can you please fixModules/Setup.stdlib.in also?

afaict that file is correct (and validated because it gets used by the testsuite)

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islingtonmiss-islington merged commitd43c265 intopython:mainFeb 23, 2023
@gpshead
Copy link
Member

I personally don't know why Modules/Setup even exists anymore, I thought the .in file template replaced it.

erlend-aasland reacted with thumbs up emoji

@msprotzmsprotz deleted the protz_md5_sha1 branchFebruary 23, 2023 22:49
@erlend-aasland
Copy link
Contributor

I personally don't know why Modules/Setup even exists anymore, I thought the .in file template replaced it.

Yes, true. I'm not sure ifModules/Setup is actually usable. If it is unusable, we should just tear it out.

JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull requestSep 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@asottileasottileasottile approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@tirantiranAwaiting requested review from tiran

@corona10corona10Awaiting requested review from corona10

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@msprotz@erlend-aasland@asottile@miss-islington@gpshead@zware@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp