Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-93649: Split exception tests from _testcapimodule.c#102173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedFeb 23, 2023•
edited
Loading

Automerge-Triggered-By: GH:erlend-aasland

@erlend-aasland
Copy link
ContributorAuthor

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the_testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?

@iritkatriel
Copy link
Member

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the_testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?

It depends, we'd need to see why it's scattered like that. Could be divided on some other criteria.

erlend-aasland reacted with thumbs up emoji

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islingtonmiss-islington merged commitefc985a intopython:mainFeb 23, 2023
@erlend-aaslanderlend-aasland deleted the split-testcapi/exceptions branchFebruary 23, 2023 17:12
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull requestSep 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@iritkatriel@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp