Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/freeze.py#102152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome LGTM!
erlend-aasland commentedFeb 23, 2023
Thanks for the review, Dong-hee! I'll wait a day or two for one of the freeze experts to chime in, just in case. |
miss-islington commentedFeb 23, 2023
Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedFeb 23, 2023
GH-102176 is a backport of this pull request to the3.11 branch. |
…eze.py (pythonGH-102152)(cherry picked from commitc3a1783)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
…GH-102152)(cherry picked from commitc3a1783)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
thesamesam commentedApr 5, 2023
This commit has causedhttps://bugs.gentoo.org/900429 (andhttps://bugs.gentoo.org/903890 because of the backport to Python 3.11) but it's unclear to me why yet. It leads to a PGO build hanging in test_tools (or running very very slowly) until disk is filled and then it'll move on. |
shr-project commentedApr 5, 2023
From my understanding which I've reported inhttps://bugs.gentoo.org/900429#c19 this change didn't directly cause the test_tools to hang. It just fixed another error which was preventing test_tools from starting properly. Before this it quickly failed with: while with this fix it shows different error and then continues for hours and hours (until killed or runs out of disk space or something): 1:44:19 load avg: 1.61 [427/427] test_tools failed (1 error) --- STDERR --- ---- END ---- --- STDERR --- ---- END ---- Total duration: 1 hour 44 min |
thesamesam commentedApr 6, 2023
Thanks Martin. I'm sorry for the noise - I think there is an issue here, but it might be on our end, and it wasn't introduced by this commit (it just exposed some pre-existing issue). |
Uh oh!
There was an error while loading.Please reload this page.