Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101936: Update the default value of fp from io.StringIO to io.BytesIO#102100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
corona10 merged 7 commits intopython:mainfromlongvhdeveloper:gh-101936
Feb 21, 2023

Conversation

@longvhdeveloper
Copy link
Contributor

@longvhdeveloperlongvhdeveloper commentedFeb 21, 2023•
edited by bedevere-bot
Loading

@ghost
Copy link

ghost commentedFeb 21, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@corona10corona10 self-assigned thisFeb 21, 2023
@corona10corona10 self-requested a reviewFebruary 21, 2023 07:33
@corona10corona10 added needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsFeb 21, 2023
Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please update the test to following codeline.

deftest_gh_98778(self):
x=urllib.error.HTTPError("url",405,"METHOD NOT ALLOWED",None,None)
self.assertEqual(getattr(x,"__notes__", ()), ())

@@ -0,0 +1 @@
HTTPError fp.read returns string instead of bytes
Copy link
Member

@corona10corona10Feb 21, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The default value of ``fp`` becomes :class:`io.BytesIO` if :exc:`~urllib.error.HTTPError` is initialized without a designated `fp` parameter. Patch by Long Vo.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10corona10 changed the titlegh-101936: HTTPError fp.read returns string instead of bytesgh-101936: Update the default value of fp from io.StringIO to io.BytesIOFeb 21, 2023
Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Almost come :)

Comment on lines 1 to 2
The default value of fp becomes:class:io.BytesIO if
:exc:~urllib.error.HTTPError is initialized without a designated fp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
The default value of fp becomes:class:io.BytesIO if
:exc:~urllib.error.HTTPError is initialized without a designatedfp
The default value of fp becomes:class:`io.BytesIO` if
:exc:`~urllib.error.HTTPError` is initialized without a designated``fp``

deftest_gh_98778(self):
x=urllib.error.HTTPError("url",405,"METHOD NOT ALLOWED",None,None)
self.assertEqual(getattr(x,"__notes__", ()), ())
self.assertEqual(isinstance(x.fp.read(),bytes),True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
self.assertEqual(isinstance(x.fp.read(),bytes),True)
self.assertIsInstance(x.fp.read(),bytes)

Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@miss-islington
Copy link
Contributor

Thanks@longvhdeveloper for the PR, and@corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 21, 2023
…o.BytesIO (pythongh-102100)(cherry picked from commit0d4c7fc)Co-authored-by: Vo Hoang Long <vohoanglong07@gmail.com>Co-authored-by: Long Vo <long.vo@linecorp.com>
@bedevere-bot
Copy link

GH-102117 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelFeb 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 21, 2023
…o.BytesIO (pythongh-102100)(cherry picked from commit0d4c7fc)Co-authored-by: Vo Hoang Long <vohoanglong07@gmail.com>Co-authored-by: Long Vo <long.vo@linecorp.com>
@bedevere-bot
Copy link

GH-102118 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelFeb 21, 2023
corona10 pushed a commit that referenced this pull requestFeb 22, 2023
…io.BytesIO (gh-102100) (gh-102117)gh-101936: Update the default value of fp from io.StringIO to io.BytesIO (gh-102100)(cherry picked from commit0d4c7fc)Co-authored-by: Long Vo <long.vo@linecorp.com>
corona10 pushed a commit that referenced this pull requestFeb 22, 2023
…io.BytesIO (gh-102100) (#102118)gh-101936: Update the default value of fp from io.StringIO to io.BytesIO (gh-102100)(cherry picked from commit0d4c7fc)Co-authored-by: Long Vo <long.vo@linecorp.com>
carljm added a commit to carljm/cpython that referenced this pull requestFeb 23, 2023
* main: (76 commits)  Fix syntax error in struct doc example (python#102160)pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)  Few coverage nitpicks for the cmath module (python#102067)pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)pythongh-100556: Improve clarity of `or` docs (python#100589)pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)pythongh-101578: Amend exception docs (python#102057)pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)  ...
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull requestSep 1, 2024
…o.BytesIO (pythongh-102100)Co-authored-by: Long Vo <long.vo@linecorp.com>
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull requestSep 1, 2024
…o.BytesIO (pythongh-102100)Co-authored-by: Long Vo <long.vo@linecorp.com>
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull requestSep 10, 2024
…o.BytesIO (pythongh-102100)Co-authored-by: Long Vo <long.vo@linecorp.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes

Assignees

@corona10corona10

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longvhdeveloper@bedevere-bot@miss-islington@corona10
[8]ページ先頭
©2009-2025 Movatter.jp