Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-99108: Import MD5 and SHA1 from HACL*#102089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 5 commits intopython:mainfrommsprotz:protz_md5_sha1
Feb 22, 2023

Conversation

@msprotz
Copy link
Contributor

@msprotzmsprotz commentedFeb 20, 2023
edited by bedevere-bot
Loading

Continuing the import of HACL* algorithms for hashlib, this time for legacy MD5 and SHA1.

@msprotz
Copy link
ContributorAuthor

(I still need to fixuppython_hacl_namespaces.h but first want to make sure this PR works.)

@msprotz
Copy link
ContributorAuthor

@gpshead these are just build errors, apparently I didn't export the right CFLAGS somewhere

before I dig further into this, would you like all of the hacl files to be bundled into a single libhacl.a? or is it ok to rely on the existing build system to build single .o files for the non-sha2 algorithms?

@gpsheadgpshead self-assigned thisFeb 21, 2023
@gpsheadgpshead marked this pull request as draftFebruary 21, 2023 05:14
@gpshead
Copy link
Member

before I dig further into this, would you like all of the hacl files to be bundled into a single libhacl.a? or is it ok to rely on the existing build system to build single .o files for the non-sha2 algorithms?

Ithink what you've done in ths PR should work fine. one .c file for each of md5 and sha1, no specific need for a library.

from a build simplicity perspective with the way we have things set up in our plethora of build configs, the lesson from the sha2 stuff was not to reuse the same .c/.o/.a with non-static symbols in multiple extension modules.(i may not have needed the .a for sha2 in the end but i decided to leave it in place when merging sha256 and sha512 into sha2 - if we don't need it setup that way in the end it could be undone later to just be the .c file as these are)

msprotz reacted with thumbs up emoji

@msprotzmsprotz marked this pull request as ready for reviewFebruary 21, 2023 18:57
@msprotz
Copy link
ContributorAuthor

Ok looks like we're good now. I'll get started on SHA3 while I wait for this one to land.

@gpsheadgpshead added 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelsFeb 22, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@gpshead for commitb3dd4fd 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@gpshead for commitb3dd4fd 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelsFeb 22, 2023
@gpsheadgpshead added the extension-modulesC modules in the Modules dir labelFeb 22, 2023
@msprotz
Copy link
ContributorAuthor

I'm not sure what to make of the buildbot run. Three failures are in test_zipfile, another one in test_asyncio, all seem unrelated to this PR.

@gpshead
Copy link
Member

I'm not sure what to make of the buildbot run. Three failures are in test_zipfile, another one in test_asyncio, all seem unrelated to this PR.

nothing to worry about. those look like flaky / poorly designed tests and/or infrastructure issues.

@gpsheadgpshead merged commitfcadc7e intopython:mainFeb 22, 2023
carljm added a commit to carljm/cpython that referenced this pull requestFeb 23, 2023
* main: (76 commits)  Fix syntax error in struct doc example (python#102160)pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)  Few coverage nitpicks for the cmath module (python#102067)pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)pythongh-100556: Improve clarity of `or` docs (python#100589)pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)pythongh-101578: Amend exception docs (python#102057)pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)  ...
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull requestSep 10, 2024
Replaces our fallback non-OpenSSL MD5 and SHA1 implementations with those from HACL* as we've already done with SHA2.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes

@tirantiranAwaiting requested review from tiran

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

+1 more reviewer

@asottileasottileasottile left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gpsheadgpshead

Labels

extension-modulesC modules in the Modules dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msprotz@gpshead@bedevere-bot@asottile

[8]ページ先頭

©2009-2025 Movatter.jp