NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-101981: Apply HOMEBREW related environment variables#102074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

corona10 merged 8 commits intopython:mainfromcorona10:gh-101981-devguide

Feb 20, 2023

Merged

gh-101981: Apply HOMEBREW related environment variables#102074

corona10 merged 8 commits intopython:mainfromcorona10:gh-101981-devguide

Feb 20, 2023

Conversation

Copy link

Member

corona10 commentedFeb 20, 2023•
edited by bedevere-bot
Loading

Issue:CI: intermittent macOS failures for make checksharedmods #101981

pythongh-101981: Make macOS CI as same as dev-guide

f9dbbf5

bedevere-bot added the awaiting core review label

Feb 20, 2023

bedevere-bot mentioned this pull request

Feb 20, 2023

CI: intermittent macOS failures for make checksharedmods#101981

Closed

corona10 requested a review fromerlend-aasland

February 20, 2023 13:29

corona10 marked this pull request as ready for review

February 20, 2023 13:29

corona10 requested a review fromezio-melotti as acode owner

February 20, 2023 13:29

corona10 added the skip news label

Feb 20, 2023

corona10 commented

Feb 20, 2023

View reviewed changes

.github/workflows/build.ymlShow resolvedHide resolved

corona10 added needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Feb 20, 2023

erlend-aasland requested changes

Feb 20, 2023

View reviewed changes

.github/workflows/build.yml OutdatedShow resolvedHide resolved

bedevere-bot removed the awaiting core review label

Feb 20, 2023

Copy link

bedevere-bot commentedFeb 20, 2023

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

bedevere-bot added the awaiting changes label

Feb 20, 2023

Update .github/workflows/build.yml

61b0e25

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

erlend-aasland reviewed

Feb 20, 2023

View reviewed changes

.github/workflows/build.yml OutdatedShow resolvedHide resolved

corona10 force-pushed thegh-101981-devguide branch fromed7e90d tob45a5a4Compare

February 20, 2023 13:35

Address code review

0894d6f

corona10 force-pushed thegh-101981-devguide branch from4f85a4c to0894d6fCompare

February 20, 2023 13:37

erlend-aasland reviewed

Feb 20, 2023

View reviewed changes

.github/workflows/build.yml OutdatedShow resolvedHide resolved

corona10 added2 commits

February 20, 2023 22:37

Address code review

990c316

Apply@hugovk's suggestion

cb01a13

corona10 requested a review fromhugovk

February 20, 2023 13:40

erlend-aasland approved these changes

Feb 20, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels

Feb 20, 2023

erlend-aasland changed the title~~gh-101981: Make macOS CI as same as dev-guide~~gh-101981: Combine macOS configure steps as recommended by the devguide

Feb 20, 2023

Copy link

Contributor

erlend-aasland commentedFeb 20, 2023

This is nice!

hugovk approved these changes

Feb 20, 2023

View reviewed changes

sobolevn reviewed

Feb 20, 2023

View reviewed changes

Copy link

Member

sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@corona10 and@erlend-aasland for fixing the CI 🎉

.github/workflows/build.ymlShow resolvedHide resolved

Revert some changes

fa06ded

corona10 removed needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Feb 20, 2023

corona10 changed the title~~gh-101981: Combine macOS configure steps as recommended by the devguide~~gh-101981: Apply HOMEBREW related environment variables.

Feb 20, 2023

corona10 changed the title~~gh-101981: Apply HOMEBREW related environment variables.~~gh-101981: Apply HOMEBREW related environment variables

Feb 20, 2023

corona10 merged commited01add intopython:main

Feb 20, 2023

bedevere-bot removed the awaiting merge label

Feb 20, 2023

corona10 deleted the gh-101981-devguide branch

February 20, 2023 15:20

Copy link

Contributor

erlend-aasland commentedFeb 20, 2023

Why not backport this?

corona10 added needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Feb 20, 2023

Copy link

Contributor

miss-islington commentedFeb 20, 2023

Thanks@corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Copy link

Contributor

miss-islington commentedFeb 20, 2023

Thanks@corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

Copy link

bedevere-bot commentedFeb 20, 2023

GH-102081 is a backport of this pull request to the3.10 branch.

bedevere-bot removed the needs backport to 3.10only security fixes label

Feb 20, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 20, 2023

pythongh-101981: Apply HOMEBREW related environment variables (python…

fc6fd58

…gh-102074)(cherry picked from commited01add)Co-authored-by: Dong-hee Na <donghee.na@python.org>

Copy link

bedevere-bot commentedFeb 20, 2023

GH-102082 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 20, 2023

pythongh-101981: Apply HOMEBREW related environment variables (python…

9652b51

…gh-102074)(cherry picked from commited01add)Co-authored-by: Dong-hee Na <donghee.na@python.org>

bedevere-bot removed the needs backport to 3.11only security fixes label

Feb 20, 2023

Copy link

MemberAuthor

corona10 commentedFeb 20, 2023

Why not backport this?

I thought that it could be a kind of new feature for the CI systems lol.
But after I read the comment from the@zooba at Discord, I change my mind about backporting this.

miss-islington added a commit that referenced this pull request

Feb 20, 2023

gh-101981: Apply HOMEBREW related environment variables (gh-102074)

95f4e2c

(cherry picked from commited01add)Co-authored-by: Dong-hee Na <donghee.na@python.org>

miss-islington added a commit that referenced this pull request

Feb 20, 2023

gh-101981: Apply HOMEBREW related environment variables (gh-102074)

1747be4

(cherry picked from commited01add)Co-authored-by: Dong-hee Na <donghee.na@python.org>

jaraco pushed a commit to jaraco/cpython that referenced this pull request

Feb 20, 2023

pythongh-101981: Apply HOMEBREW related environment variables (python…

b57a039

…gh-102074)

jaraco mentioned this pull request

Feb 20, 2023

gh-88233: zipfile: refactor _strip_extra#102083

Closed

AlexWaygood mentioned this pull request

Feb 20, 2023

Set HOMEBREW_NO_INSTALL_CLEANUP to speedup brew installspython/typeshed#9713

Merged

carljm added a commit to carljm/cpython that referenced this pull request

Feb 20, 2023

Merge branch 'main' into inlinecomp2

9f0fc5b

* main: (60 commits)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)pythongh-97786: Fix compiler warnings in pytime.c (python#101826)pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)  Misc improvements to the float tutorial (pythonGH-102052)pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)  Add missing 'is' to `cmath.log()` docstring (python#102049)pythongh-100210: Correct the comment link for unescaping HTML (python#100212)pythongh-97930: Also include subdirectory in makefile. (python#102030)pythongh-99735: Use required=True in argparse subparsers example (python#100927)  Fix incorrectly documented attribute in csv docs (python#101250)pythonGH-84783: Make the slice object hashable (pythonGH-101264)  ...

AlexWaygood mentioned this pull request

Feb 21, 2023

Add some more environment variables to speedup brew installs in CIpython/typeshed#9786

Merged

carljm added a commit to carljm/cpython that referenced this pull request

Feb 22, 2023

Merge branch 'main' into inlinecomp

544b30c

* main: (225 commits)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)pythongh-97786: Fix compiler warnings in pytime.c (python#101826)pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)  Misc improvements to the float tutorial (pythonGH-102052)pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)  Add missing 'is' to `cmath.log()` docstring (python#102049)pythongh-100210: Correct the comment link for unescaping HTML (python#100212)pythongh-97930: Also include subdirectory in makefile. (python#102030)pythongh-99735: Use required=True in argparse subparsers example (python#100927)  Fix incorrectly documented attribute in csv docs (python#101250)pythonGH-84783: Make the slice object hashable (pythonGH-101264)  ...