NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-102013: Add PyUnstable_GC_VisitObjects#102014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pablogsal merged 22 commits intopython:mainfromjbower-fb:gcvisitobjs

Mar 14, 2023

Merged

gh-102013: Add PyUnstable_GC_VisitObjects#102014

pablogsal merged 22 commits intopython:mainfromjbower-fb:gcvisitobjs

Mar 14, 2023

Conversation

Copy link

Contributor

jbower-fb commentedFeb 18, 2023•
edited by bedevere-bot
Loading

Issue:Add a public C-API function to iterate over GC’able objects #102013

Add PyGC_VisitObjects

c4a91e0

Co-authored-by: Brett Simmers <bsimmers@meta.com>

jbower-fb requested a review frompablogsal as acode owner

February 18, 2023 00:47

Copy link

ghost commentedFeb 18, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.

bedevere-bot added the awaiting review label

Feb 18, 2023

bedevere-bot mentioned this pull request

Feb 18, 2023

Add a public C-API function to iterate over GC’able objects#102013

Closed

Copy link

bedevere-bot commentedFeb 18, 2023

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

blurb-itbotand others added2 commits

February 18, 2023 00:55

📜🤖 Added by blurb_it.

57edf6d

Remove from Limited API

447bb53

pablogsal self-assigned this

Feb 19, 2023

hauntsaninjaand others added3 commits

February 20, 2023 11:39

Merge branch 'main' into gcvisitobjs

d4f9505

Updated to "unstable" API, protect against GC and current object dele…

d34a900

…tion, add ability to terminate iteration early with test.

Merge branch 'gcvisitobjs' ofhttps://github.com/jbower-fb/cpython-jb…

7c1fbbb

…owerfb into gcvisitobjs

erlend-aasland reviewed

Feb 23, 2023

View reviewed changes

Misc/NEWS.d/next/C API/2023-02-18-00-55-14.gh-issue-102013.83mrtI.rst OutdatedShow resolvedHide resolved

Modules/_testcapimodule.c OutdatedShow resolvedHide resolved

Modules/gcmodule.c OutdatedShow resolvedHide resolved

Include/objimpl.hShow resolvedHide resolved

jbower-fband others added10 commits

February 23, 2023 11:53

Fix formatting in Modules/_testcapimodule.c

9b0c461

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Fix formatting in Modules/_testcapimodule.c

29f7f88

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Fix formatting in Modules/_testcapimodule.c

e16f1e3

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Fix formatting in Modules/_testcapimodule.c

024ee30

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Fix formatting in Modules/gcmodule.c

bd65abb

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Fix formatting in Modules/gcmodule.c

f03e581

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Fix formatting in Modules/gcmodule.c

16ea0d6

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Simplify test in Modules/_testcapimodule.c

369e199

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Address minor review comments and add documentation.

219154a

Merge branch 'main' into gcvisitobjs

be5b7f0

Copy link

ContributorAuthor

jbower-fb commentedFeb 24, 2023

Thank you for the feedback@erlend-aasland. I'll try to get better atPEP-7 compliance in future!

Copy link

ContributorAuthor

jbower-fb commentedMar 8, 2023

Hey@pablogsal, any thoughts on this?

encukou approved these changes

Mar 8, 2023

View reviewed changes

Copy link

Member

encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

API-wise, this looks good!

Include/objimpl.h

		@@ -157,6 +157,25 @@ PyAPI_FUNC(int) PyGC_Enable(void);
		PyAPI_FUNC(int) PyGC_Disable(void);
		PyAPI_FUNC(int) PyGC_IsEnabled(void);


		#if !defined(Py_LIMITED_API)

Copy link

Member

encukouMar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can put this inInclude/cpython/objimpl.h, which is only included for non-limited API. But that's not a blocker.

Copy link

ContributorAuthor

jbower-fbMar 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not very familiar with the conventions here, is that what we should do with public API (even if it's unstable)?

Copy link

Member

encukouMar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes.

Details are in the Devguide.

bedevere-bot added awaiting merge and removed awaiting review labels

Mar 8, 2023

Copy link

Member

pablogsal commentedMar 8, 2023

Hey@pablogsal, any thoughts on this?

Will make a review later this week. Apologies for the delay but I am a bit swamped recently

erlend-aasland reviewed

Mar 10, 2023

View reviewed changes

Doc/c-api/gcsupport.rst OutdatedShow resolvedHide resolved

Modules/_testcapimodule.c OutdatedShow resolvedHide resolved

jbower-fband others added5 commits

March 11, 2023 10:54

Update Doc/c-api/gcsupport.rst

5752f1c

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Update Modules/_testcapimodule.c

1512004

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Update Modules/_testcapimodule.c

87a5b56

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Minor doc tweaks from review

295f7dd

Merge branch 'python:main' into gcvisitobjs

ed06dff

pablogsal approved these changes

Mar 13, 2023

View reviewed changes

Copy link

Member

pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Apologies for the delay although the advantage of being late is that everyone has already done an excellent job with the reviews.

LGTM

Thanks a lot for the patience and understanding@jbower-fb and thanks for the great work :)

Merge branch 'main' into gcvisitobjs

620043b

pablogsal changed the title~~gh-102013: Add PyGC_VisitObjects~~gh-102013: Add PyUnstable_GC_VisitObjects

Mar 14, 2023

pablogsal merged commitcbd3fbf intopython:main

Mar 14, 2023

bedevere-bot removed the awaiting merge label

Mar 14, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Mar 14, 2023

Merge branch 'main' into inlinecomp2

6c5f269

* main: (50 commits)pythongh-102674: Remove _specialization_stats from Lib/opcode.py (python#102685)pythongh-102660: Handle m_copy Specially for the sys and builtins Modules (pythongh-102661)pythongh-102354: change python3 to python in docs examples (python#102696)pythongh-81057: Add a CI Check for New Unsupported C Global Variables (pythongh-102506)pythonGH-94851: check unicode consistency of static strings in debug mode (python#102684)pythongh-100315: clarification to `__slots__` docs. (python#102621)pythonGH-100227: cleanup initialization of global interned dict (python#102682)  doc: Remove a duplicate 'versionchanged' in library/asyncio-task (pythongh-102677)pythongh-102013: Add PyUnstable_GC_VisitObjects (python#102014)pythonGH-102670: Use sumprod() to simplify, speed up, and improve accuracy of statistics functions (pythonGH-102649)pythongh-102627: Replace address pointing toward malicious web page (python#102630)pythongh-98831: Use DECREF_INPUTS() more (python#102409)pythongh-101659: Avoid Allocation for Shared Exceptions in the _xxsubinterpreters Module (pythongh-102659)pythongh-101524: Fix the ChannelID tp_name (pythongh-102655)pythongh-102069: Fix `__weakref__` descriptor generation for custom dataclasses (python#102075)pythongh-98169 dataclasses.astuple support DefaultDict (python#98170)pythongh-102650: Remove duplicate include directives from multiple source files (python#102651)pythonGH-100987: Don't cache references to the names and consts array in `_PyEval_EvalFrameDefault`. (python#102640)pythongh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct (python#102562)pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102631)  ...