NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.4k

gh-102011: use sys.exception() instead of sys.exc_info() in docs where possible#102012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

iritkatriel merged 4 commits intopython:mainfromiritkatriel:exc_info_doc

Feb 20, 2023

Merged

gh-102011: use sys.exception() instead of sys.exc_info() in docs where possible#102012

iritkatriel merged 4 commits intopython:mainfromiritkatriel:exc_info_doc

Feb 20, 2023

Conversation

Copy link

Member

iritkatriel commentedFeb 18, 2023•
edited by bedevere-bot
Loading

Issue:Some of the docs no longer need to mention sys.exc_info() #102011

pythongh-102011: use sys.exception() instead of sys.exc_info() in doc…

93a9554

…s where possible

bedevere-bot added the awaiting core review label

Feb 18, 2023

bedevere-bot mentioned this pull request

Feb 18, 2023

Some of the docs no longer need to mention sys.exc_info()#102011

Closed

bedevere-bot added docs

Documentation in the Doc dir

skip news labels

Feb 18, 2023

iritkatriel requested review fromCAM-Gerlach anderlend-aasland

February 20, 2023 10:13

erlend-aasland reviewed

Feb 20, 2023

View reviewed changes

Doc/library/traceback.rst OutdatedShow resolvedHide resolved

iritkatrieland others added2 commits

February 20, 2023 10:31

returned by

fae1e49

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Merge branch 'main' into exc_info_doc

57752ef

TeamSpen210 reviewed

Feb 20, 2023

View reviewed changes

Doc/library/traceback.rst Outdated

		@@ -17,8 +17,7 @@ interpreter.
		.. index:: object: traceback

		The module uses traceback objects --- this is the object type that is stored in
		the :data:`sys.last_traceback` variable and returned as the third item from
		:func:`sys.exc_info`.
		the :data:`sys.last_traceback` variable and returned by :func:`sys.exception`.

Copy link

TeamSpen210Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like this is missing.__traceback__?

fix definition of traceback type

4078acc

erlend-aasland approved these changes

Feb 20, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Feb 20, 2023

iritkatriel merged commit4d3bc89 intopython:main

Feb 20, 2023

bedevere-bot removed the awaiting merge label

Feb 20, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Feb 20, 2023

Merge branch 'main' into inlinecomp2

9f0fc5b

* main: (60 commits)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)pythongh-97786: Fix compiler warnings in pytime.c (python#101826)pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)  Misc improvements to the float tutorial (pythonGH-102052)pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)  Add missing 'is' to `cmath.log()` docstring (python#102049)pythongh-100210: Correct the comment link for unescaping HTML (python#100212)pythongh-97930: Also include subdirectory in makefile. (python#102030)pythongh-99735: Use required=True in argparse subparsers example (python#100927)  Fix incorrectly documented attribute in csv docs (python#101250)pythonGH-84783: Make the slice object hashable (pythonGH-101264)  ...

Copy link

Member

CAM-Gerlach commentedFeb 21, 2023

Should we backport this to 3.11, sincesys.exception was introduced in that version? Or is there a reason this needs to stay 3.12 only?

Copy link

Contributor

erlend-aasland commentedFeb 21, 2023

SGTM,@CAM-Gerlach

erlend-aasland added the needs backport to 3.11only security fixes label

Feb 21, 2023

Copy link

Contributor

miss-islington commentedFeb 21, 2023

Thanks@iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 21, 2023

pythongh-102011: use sys.exception() instead of sys.exc_info() in doc…

69f5000

…s where possible (pythonGH-102012)(cherry picked from commit4d3bc89)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

Copy link

bedevere-bot commentedFeb 21, 2023

GH-102101 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Feb 21, 2023

miss-islington added a commit that referenced this pull request

Feb 21, 2023

gh-102011: use sys.exception() instead of sys.exc_info() in docs wher…

78eee76

…e possible (GH-102012)(cherry picked from commit4d3bc89)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

carljm added a commit to carljm/cpython that referenced this pull request

Feb 22, 2023

Merge branch 'main' into inlinecomp

544b30c

* main: (225 commits)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)pythongh-97786: Fix compiler warnings in pytime.c (python#101826)pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)  Misc improvements to the float tutorial (pythonGH-102052)pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)  Add missing 'is' to `cmath.log()` docstring (python#102049)pythongh-100210: Correct the comment link for unescaping HTML (python#100212)pythongh-97930: Also include subdirectory in makefile. (python#102030)pythongh-99735: Use required=True in argparse subparsers example (python#100927)  Fix incorrectly documented attribute in csv docs (python#101250)pythonGH-84783: Make the slice object hashable (pythonGH-101264)  ...

carljm added a commit to carljm/cpython that referenced this pull request

Feb 23, 2023

Merge branch 'main' into lockfreecp

b257a16

* main: (76 commits)  Fix syntax error in struct doc example (python#102160)pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)  Few coverage nitpicks for the cmath module (python#102067)pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)pythongh-100556: Improve clarity of `or` docs (python#100589)pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)pythongh-101578: Amend exception docs (python#102057)pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)  ...