Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-97930: Apply changes from importlib_resources 5.12.#102010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jaraco commentedFeb 18, 2023
Those test failures are interesting. They certainly seem related to the changes. But that doesn't explain why the tests pass for me locally or why they pass in importlib_resources. I'll continue to investigate. |
db3a1dd to4d92e56Comparejaraco commentedFeb 18, 2023
Aah. The issue was that new files were added but not included in the commit (the usual foot gun aka git). I probably wouldn't have encountered that error had I been usingjj. |
4d92e56 to0660828Comparejaraco commentedFeb 18, 2023
The remaining test is failing for unrelated reasons. Merging. Thanks for the review! |
bedevere-bot commentedFeb 18, 2023
|
bedevere-bot commentedFeb 18, 2023
|
bedevere-bot commentedFeb 18, 2023
|
bedevere-bot commentedFeb 18, 2023
|
jaraco commentedFeb 18, 2023
I suspect the buildbot failures are due to missing directory declarations. Will investigate. |
Uh oh!
There was an error while loading.Please reload this page.