Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove or update bitbucket links#101963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JulienPalard merged 2 commits intopython:mainfromsblondon:bitbucket-broken-link
Mar 8, 2023

Conversation

sblondon
Copy link
Contributor

Since Mercurial removal from bitbucket.org, some links are broken.
In this PR, they are replaced by github.com or webarchive links if available. Otherwise, they are removed.

I don't think news are needed (no blurb).

arhadthedev reacted with thumbs up emoji
@@ -1908,7 +1908,7 @@ def test_resolve_common(self):

@os_helper.skip_unless_symlink
def test_resolve_dot(self):
# See https://bitbucket.org/pitrou/pathlib/issue/9/pathresolve-fails-on-complex-symlinks
# Seehttp://web.archive.org/web/20200623062557/https://bitbucket.org/pitrou/pathlib/issues/9/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure this comment really adds much; better to just remove it than use an archive link.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The link was added in thesame commit than the unit test so, at least when introduced, it meant something. I don't have a strong opinion about this link but I think it would be better to keep it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@serhiy-storchaka,@pitrou Do either of you remember enough context to suggest a replacement for this comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Well, the link shows in which context the test was introduced in the first place. It doesn't hurt to keep it.

@sblondonsblondonforce-pushed thebitbucket-broken-link branch 3 times, most recently from33e61d2 to532595bCompareFebruary 17, 2023 10:32
Since Mercurial removal from bitbucket.org, some links are broken.They are replaced by github.com or webarchive.org links if available. Otherwise, they are removed.
@JulienPalardJulienPalard merged commit7d801f2 intopython:mainMar 8, 2023
carljm added a commit to carljm/cpython that referenced this pull requestMar 8, 2023
* main:pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)pythongh-102507 Remove invisible pagebreak characters (python#102531)pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)  Remove or update bitbucket links (pythonGH-101963)pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)  Fix style in argparse.rst (python#101733)  Post 3.12.0a6  fix typo in async generator code field name `ag_code` (python#102448)  Python 3.12.0a6
@sblondonsblondon deleted the bitbucket-broken-link branchMarch 9, 2023 07:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pitroupitroupitrou left review comments

@zwarezwarezware left review comments

@JulienPalardJulienPalardJulienPalard approved these changes

@barneygalebarneygaleAwaiting requested review from barneygalebarneygale is a code owner

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@sblondon@JulienPalard@pitrou@zware@bedevere-bot@hauntsaninja

[8]ページ先頭

©2009-2025 Movatter.jp