Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99108: Refactor _sha256 & _sha512 into _sha2.#101924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 13 commits intopython:mainfromgpshead:build/sha2
Feb 16, 2023

Conversation

gpshead
Copy link
Member

@gpsheadgpshead commentedFeb 15, 2023•
edited
Loading

This merges their code. They're backed by the same single HACL* static library, having them be a single module simplifies maintenance.

This should unbreak the wasm enscripten builds that currently fail due to linking in --whole-archive mode and the HACL* library appearing twice.

Long unnoticed error fixed: _sha512.SHA384Type was doubly assigned and was actually SHA512Type. Nobody depends on those internal names.

This is a followup to PRs#101707 and#101917.

This merges their code. They're backed by the same single HACL* star staticlibrary, having them be a single module simplifies maintenance.This should unbreak the wasm enscripten builds that currently fail due tolinking in --whole-archive mode and the HACL* library appearing twice.Long unnoticed error fixed: `_sha512.SHA384Type` was doubly assigned and wasactually SHA512Type. Nobody depends on those internal names.
@gpsheadgpshead self-assigned thisFeb 15, 2023
@gpsheadgpshead added extension-modulesC modules in the Modules dir buildThe build process and cross-build labelsFeb 15, 2023
@gpsheadgpshead added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 15, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@gpshead for commit4c6a4fb 🤖

If you want to schedule another build, you need to add the:hammer: test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 15, 2023
@gpsheadgpshead marked this pull request as ready for reviewFebruary 15, 2023 03:04
@erlend-aasland
Copy link
Contributor

BTW, I'm pretty sure the refleaks are related to#101908.

@gpsheadgpshead added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 16, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@gpshead for commitfb6454d 🤖

If you want to schedule another build, you need to add the:hammer: test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 16, 2023
@gpsheadgpshead added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 16, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@gpshead for commit32b8f91 🤖

If you want to schedule another build, you need to add the:hammer: test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 16, 2023
@gpsheadgpshead added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 16, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@gpshead for commitb67918d 🤖

If you want to schedule another build, you need to add the:hammer: test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 16, 2023
@gpsheadgpshead merged commit0b13575 intopython:mainFeb 16, 2023
@gpsheadgpshead deleted the build/sha2 branchFebruary 16, 2023 06:08
picnixz added a commit that referenced this pull requestMar 3, 2025
Since we plan to introduce a built-in implementation for HMAC based on HACL*,it becomes important for the HMAC tests to be flexible enough to avoid codeduplication.In addition to the new layout based on mixin classes, we extend test coverage byalso testing the `__repr__` of HMAC objects and the HMAC one-shot functions.We also fix the import to `_sha256` which, sincegh-101924, resulted in some tests beingskipped as the module is no more available (its content was moved to the `_sha2` module).
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Since we plan to introduce a built-in implementation for HMAC based on HACL*,it becomes important for the HMAC tests to be flexible enough to avoid codeduplication.In addition to the new layout based on mixin classes, we extend test coverage byalso testing the `__repr__` of HMAC objects and the HMAC one-shot functions.We also fix the import to `_sha256` which, sincepythongh-101924, resulted in some tests beingskipped as the module is no more available (its content was moved to the `_sha2` module).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@msprotzmsprotzmsprotz left review comments

@erlend-aaslanderlend-aaslanderlend-aasland left review comments

@tirantiranAwaiting requested review from tirantiran is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

@gpsheadgpshead

Labels
buildThe build process and cross-buildextension-modulesC modules in the Modules dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@gpshead@bedevere-bot@erlend-aasland@msprotz
[8]ページ先頭
©2009-2025 Movatter.jp