Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101907: Removes use of non-standard C++ extension from Include/cpython/code.h#101909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
zooba wants to merge2 commits intopython:mainfromzooba:gh-101907

Conversation

zooba
Copy link
Member

@zoobazooba commentedFeb 14, 2023•
edited by bedevere-bot
Loading

Updates all references to use the macros, so that changes are localised to the header file.

@zooba
Copy link
MemberAuthor

Another possible fix (that I haven't tested yet) would be to move this struct into a private header. I don't have any strong preference, but I'm also not familiar with its background and intended use.

@markshannon
Copy link
Member

markshannon commentedFeb 14, 2023•
edited
Loading

This is C11, not C++.

What problem is this causing? Looks like I should have read the issue.

@markshannon
Copy link
Member

Anonymous unions are quite useful, especially for inserting unions into a struct and retaining API compatibility. It's a shame we can't use them.

@zooba
Copy link
MemberAuthor

I agree they're useful, but I don't need to be convinced. We have to win over the C++ committee 😄 And then wait a decade for it to be generally available in all the compilers we support.

Incidentally, I noticed theSET macro, so I fixed it and am switching the assignments to use that.

@zooba
Copy link
MemberAuthor

#101912 is an alternate PR to this one

@zooba
Copy link
MemberAuthor

We prefer#101912

@zoobazooba closed thisFeb 15, 2023
@zoobazooba deleted the gh-101907 branchFebruary 15, 2023 21:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@zooba@markshannon@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp