Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-101819: Remove _PyWindowsConsoleIO_Type from the Windows DLL#101904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
erlend-aasland commentedFeb 14, 2023
Does this work for you,@zooba? Re.#101819 (comment) |
zooba commentedFeb 14, 2023
Can you remove the I'd kinda like to see a few more |
erlend-aasland commentedFeb 14, 2023
The one in |
zooba commentedFeb 14, 2023
I was thinking the definition in Provided we're not changing any supported public API, it's fine. |
erlend-aasland commentedFeb 14, 2023
AFAICS, |
erlend-aasland commentedFeb 14, 2023
Perhaps we should wait for#101919 to land, before merging this 😄 cc.@ericsnowcurrently |
ericsnowcurrently commentedFeb 14, 2023
Don't worry about waiting for that PR to merge. I don't think it conflicts. Regardless, I don't mind fixing my branch if needed. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington commentedFeb 15, 2023
Status check is done, and it's a success ✅. |
erlend-aasland commentedFeb 15, 2023
Thanks for the reviews; highly appreciated. |
Uh oh!
There was an error while loading.Please reload this page.
_ioextension module #101819Automerge-Triggered-By: GH:erlend-aasland