Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-101819: Remove _PyWindowsConsoleIO_Type from the Windows DLL#101904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
miss-islington merged 4 commits intopython:mainfromerlend-aasland:winconsoletype
Feb 15, 2023

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedFeb 14, 2023
edited
Loading

Automerge-Triggered-By: GH:erlend-aasland

@erlend-aasland
Copy link
ContributorAuthor

Does this work for you,@zooba? Re.#101819 (comment)

@zooba
Copy link
Member

Can you remove theCheck macro entirely? It's got to go if we're supporting multiple instances of the module, so may as well just go now.

I'd kinda like to see a few moretstate parameters being passed around, but I guess if the lower level APIs don't take them then there's nowhere to pass them 🤷‍♂️

@erlend-aasland
Copy link
ContributorAuthor

Can you remove theCheck macro entirely? It's got to go if we're supporting multiple instances of the module, so may as well just go now.

The one inPC/_testconsole.c,Python/pylifecycle.c, or both? I assume the assert inModules/_io/winconsoleio.c should stay.

@zooba
Copy link
Member

I was thinking the definition in_iomodule.h and anywhere it's used, but I see now that's fully internal anyway.

Provided we're not changing any supported public API, it's fine.

@erlend-aasland
Copy link
ContributorAuthor

Provided we're not changing any supported public API, it's fine.

AFAICS,_iomodule.h is not included inPython.h, so we should be fine.

@erlend-aasland
Copy link
ContributorAuthor

Perhaps we should wait for#101919 to land, before merging this 😄 cc.@ericsnowcurrently

@ericsnowcurrently
Copy link
Member

Don't worry about waiting for that PR to merge. I don't think it conflicts. Regardless, I don't mind fixing my branch if needed.

erlend-aasland reacted with heart emoji

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islingtonmiss-islington merged commiteb0c485 intopython:mainFeb 15, 2023
@erlend-aaslanderlend-aasland deleted the winconsoletype branchFebruary 15, 2023 13:22
@erlend-aasland
Copy link
ContributorAuthor

Thanks for the reviews; highly appreciated.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland@zooba@ericsnowcurrently@miss-islington@kumaraditya303@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp