Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101860: Expose __name__ on property#101876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 4 commits intopython:mainfromeltoder:feature/property-name
Feb 20, 2024

Conversation

eltoder
Copy link
Contributor

@eltodereltoder commentedFeb 13, 2023•
edited by bedevere-bot
Loading

Useful for introspection and consistent with functions and other descriptors.

funkyfuture reacted with thumbs up emoji
@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@eltodereltoderforce-pushed thefeature/property-name branch 3 times, most recently from05db108 to9c956c7CompareFebruary 13, 2023 18:00
@serhiy-storchaka
Copy link
Member

@eltoder, there are a lot of conflicts now. Could you please update the branch?

Useful for introspection and consistent with functions and otherdescriptors.
@eltoder
Copy link
ContributorAuthor

@serhiy-storchaka Done

@serhiy-storchaka
Copy link
Member

Thank you. I knew I could count on you.

eltoder reacted with thumbs up emoji

@eltoder
Copy link
ContributorAuthor

@serhiy-storchaka I made__name__ default tofget.__name__ when possible. What do you think?

Raise AttributeError if no fget or it doesn't have `__name__`.
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. And I like to to review more of your PRs.

@serhiy-storchakaserhiy-storchaka merged commitc0b0c2f intopython:mainFeb 20, 2024
@eltodereltoder deleted the feature/property-name branchFebruary 20, 2024 15:33
@eltoder
Copy link
ContributorAuthor

Thank you!

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull requestMar 4, 2024
Useful for introspection and consistent with functions and otherdescriptors.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
Useful for introspection and consistent with functions and otherdescriptors.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull requestJan 22, 2025
Useful for introspection and consistent with functions and otherdescriptors.
dangotbanned added a commit to narwhals-dev/narwhals that referenced this pull requestApr 23, 2025
Following where `__name__` used to be sourced from-python/cpython#101876
MarcoGorelli pushed a commit to narwhals-dev/narwhals that referenced this pull requestApr 26, 2025
* chore(typing): fix `check_docstrings` `Path` warning`pyright` did a good job spotting that one* chore: Use `dir(...)` instead of `.__dir__()`Fixes 2/6 errors and shrinks the script* chore(typing): Fix 2 more errorsThese have been popping up and bugging me for 2 weeks 🙈#2351 (comment)* chore(typing): Fix the last 2 as well* chore: Simplify the rest* chore(typing): Ignore remaining in `utils`* chore(typing): Ignore everything in `tpch`These are all the same issue, can be fixed with a constrained `TypeVar`* fix: pre-`3.13` compat?Following where `__name__` used to be sourced from-python/cpython#101876* chore(typing): Fix some of the new `tpch` ignoresThe rest seem pretty unavoidable* fix: don't clobber `typing` 🤦‍♂️https://github.com/narwhals-dev/narwhals/actions/runs/14624570842/job/41032838053?pr=2426
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@eltoder@bedevere-bot@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp