NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-100425: Update tutorial docs related to sum() accuracy#101854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

rhettinger merged 1 commit intopython:mainfromneuralstring:patch-1

Feb 19, 2023

Merged

gh-100425: Update tutorial docs related to sum() accuracy#101854

rhettinger merged 1 commit intopython:mainfromneuralstring:patch-1

Feb 19, 2023

Conversation

Copy link

Contributor

neuralstring commentedFeb 12, 2023•
edited by bedevere-bot
Loading

Related to#100426

Issue:Improve accuracy of builtin sum() for float inputs #100425

Update tutorial docs related to sum() accuracy

518c1af

Related topython#100426

Copy link

ghost commentedFeb 12, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Feb 12, 2023

arhadthedev reviewed

Feb 12, 2023

View reviewed changes

Doc/tutorial/stdlib2.rst

Comment on lines -397 to 398

		>>>sum([0.1]*10) == 1.0
		>>> 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 == 1.0
		False

Copy link

Member

arhadthedevFeb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can confirm:

RunningRelease|x64interpreter...Python3.12.0a5+ (heads/main:dfc2e065a2,Feb122023,11:14:56) [MSCv.192964bit (AMD64)]onwin32Type"help","copyright","credits"or"license"formoreinformation.>>>sum([0.1]*10)==1.0True>>>0.1+0.1+0.1+0.1+0.1+0.1+0.1+0.1+0.1+0.1==1.0False

@rhettinger as an author of the referenced PR.

arhadthedev changed the title~~Update tutorial docs related to sum() accuracy~~gh-100425: Update tutorial docs related to sum() accuracy

Feb 12, 2023

bedevere-bot mentioned this pull request

Feb 12, 2023

Improve accuracy of builtin sum() for float inputs#100425

Closed

rhettinger self-assigned this

Feb 15, 2023

rhettinger requested changes

Feb 15, 2023

View reviewed changes

Copy link

Contributor

rhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please adddoctest directives throughout this page. It would have been nice for this issue to have been detected automatically.

bedevere-bot removed the awaiting review label

Feb 15, 2023

Copy link

bedevere-bot commentedFeb 15, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.