Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-100176: Remove outdated Tools/{io,cc,string}bench#101853

Merged
hugovk merged 5 commits intopython:mainfrom
hugovk:rm-tools-io-cc-stringbench
Feb 17, 2024
Merged

gh-100176: Remove outdated Tools/{io,cc,string}bench#101853
hugovk merged 5 commits intopython:mainfrom
hugovk:rm-tools-io-cc-stringbench

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commentedFeb 12, 2023
edited
Loading

erlend-aasland and arhadthedev reacted with thumbs up emoji
@arhadthedev
Copy link
Member

BTW, it allows to closegh-32135 as outdated.

hugovk and erlend-aasland reacted with thumbs up emoji

@sobolevn
Copy link
Member

@rhettinger had some opinion on this as well.

@erlend-aasland
Copy link
Contributor

Sad to see Håvamål go 😢👁️

1.
Gáttir allar,
áðr gangi fram,
um skoðask skyli,
um skyggnast skyli,
því at óvíst er at vita,
hvar óvinir
sitja á fleti fyrir.
2.
Gefendr heilir!
Gestr er inn kominn,
hvar skal sitja sjá?
Mjök er bráðr,
sá er á bröndum skal
síns of freista frama.
3.
Elds er þörf,
þeims inn er kominn
ok á kné kalinn;
matar ok váða
er manni þörf,
þeim er hefr um fjall farit.
4.
Vatns er þörf,
þeim er til verðar kemr,
þerru ok þjóðlaðar,
góðs of æðis,
ef sér geta mætti,
orðs ok endrþögu.
5.
Vits er þörf,
þeim er víða ratar;
dælt er heima hvat;
at augabragði verðr,
sá er ekki kann
ok með snotrum sitr.
6.
At hyggjandi sinni
skyli-t maðr hræsinn vera,
heldr gætinn at geði;
þá er horskr ok þögull
kemr heimisgarða til,
sjaldan verðr víti vörum,
því at óbrigðra vin
fær maðr aldregi
en mannvit mikit.
7.
Inn vari gestr,
er til verðar kemr,
þunnu hljóði þegir,
eyrum hlýðir,
en augum skoðar;
svá nýsisk fróðra hverr fyrir.
8.
Hinn er sæll,
er sér of getr
lof ok líknstafi;
ódælla er við þat,
er maðr eiga skal
annars brjóstum í.

@hugovk
Copy link
MemberAuthor

(Resolved conflict)

@hugovkhugovk merged commitaba37d4 intopython:mainFeb 17, 2024
@hugovkhugovk deleted the rm-tools-io-cc-stringbench branchFebruary 17, 2024 21:17
@Sophist-UK
Copy link

I would have commented sooner had I known that this was about to happen. It would have been helpful if someone had commented inmy PR toccbench.py that this was being considered so that I would have been notified and might have had a chance to comment before it happened.

I believe it was clear from theextensive discussion about the shortcomings of the current GIL in faster-cpython that theccbench script is still useful - because it clearly identifies an ongoing performance issue when multithreading with one or more CPU-heavy threads.

That said, I do understand that performance scripts do not really have a place in the cpython source code repo, but unfortunately I do not have the time to rework the updatedccbench script for the pyperformance suite, so I guess it is going to just disappear.

@hugovk
Copy link
MemberAuthor

I would have commented sooner had I known that this was about to happen. It would have been helpful if someone had commented inmy PR toccbench.py that this was being considered so that I would have been notified and might have had a chance to comment before it happened.

Apologies, I'll ping next time this sort of thing comes up. (btw we wouldn't be allowed to merge your PR because it looks like the CLA isn't signed.)

That said, I do understand that performance scripts do not really have a place in the cpython source code repo, but unfortunately I do not have the time to rework the updatedccbench script for the pyperformance suite, so I guess it is going to just disappear.

Yep, in general, benchmarks are much more useful in pyperformace, because they're run often and people pay attention to their results.

The code hasn't disappeared, it's still in the 3.12 and older branches, and in Git history.

And of course, if there's consensus we can easily revert/re-add bits of this.

@Sophist-UK
Copy link

btw we wouldn't be allowed to merge your PR because it looks like the CLA isn't signed.

Go look at the PR history - I signed the CLA and the relevant label was added. Later the label was removed for some reason unknown to me..

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull requestMar 4, 2024
…1853)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
…1853)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull requestJan 22, 2025
…1853)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Meta issue: clean up redundant compat code

6 participants

@hugovk@arhadthedev@sobolevn@erlend-aasland@Sophist-UK@bedevere-bot

Comments


[8]ページ先頭

©2009-2026 Movatter.jp