Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
gh-100176: Remove outdated Tools/{io,cc,string}bench#101853
gh-100176: Remove outdated Tools/{io,cc,string}bench#101853hugovk merged 5 commits intopython:mainfrom
Conversation
arhadthedev commentedFeb 12, 2023
BTW, it allows to closegh-32135 as outdated. |
sobolevn commentedFeb 12, 2023
@rhettinger had some opinion on this as well. |
erlend-aasland commentedFeb 14, 2023
Sad to see Håvamål go 😢👁️ cpython/Tools/iobench/iobench.py Lines 482 to 548 in81e3aa8
|
hugovk commentedApr 27, 2023
(Resolved conflict) |
Sophist-UK commentedFeb 18, 2024
I would have commented sooner had I known that this was about to happen. It would have been helpful if someone had commented inmy PR to I believe it was clear from theextensive discussion about the shortcomings of the current GIL in faster-cpython that the That said, I do understand that performance scripts do not really have a place in the cpython source code repo, but unfortunately I do not have the time to rework the updated |
hugovk commentedFeb 18, 2024
Apologies, I'll ping next time this sort of thing comes up. (btw we wouldn't be allowed to merge your PR because it looks like the CLA isn't signed.)
Yep, in general, benchmarks are much more useful in pyperformace, because they're run often and people pay attention to their results. The code hasn't disappeared, it's still in the 3.12 and older branches, and in Git history. And of course, if there's consensus we can easily revert/re-add bits of this. |
Sophist-UK commentedFeb 18, 2024
Go look at the PR history - I signed the CLA and the relevant label was added. Later the label was removed for some reason unknown to me.. |
…1853)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
…1853)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
…1853)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Closes#32135.
Closes#100176.
Closes#100197.
See:
Replaces and: