Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
[3.11] gh-101845: pyspecific: Fix i18n for availability directive (GH-101846)#101852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…honGH-101846)pyspecific: Fix i18n for availability directiveIf the directive has content, the previous code would nest paragraphnodes from that content inside a general paragraph node, which confusesSphinx and leads it to drop the content when translating. Instead, use acontainer node for the body.Also use set_source_info so that any warnings have location info.(cherry picked from commit6ef6915)Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
This was referencedFeb 12, 2023
JulienPalard approved these changesFeb 12, 2023
JulienPalard added a commit to python/python-docs-fr that referenced this pull requestFeb 12, 2023
Pourpython/cpython#101852Reviewed-on:https://git.afpy.org/AFPy/python-docs-fr/pulls/34Co-authored-by: Julien Palard <julien@palard.fr>Co-committed-by: Julien Palard <julien@palard.fr>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
pyspecific: Fix i18n for availability directive
If the directive has content, the previous code would nest paragraph
nodes from that content inside a general paragraph node, which confuses
Sphinx and leads it to drop the content when translating. Instead, use a
container node for the body.
Also use set_source_info so that any warnings have location info.
(cherry picked from commit6ef6915)
Co-authored-by: Jean Abou-Samrajean@abou-samra.fr