Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-101845: pyspecific: Fix i18n for availability directive#101846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JulienPalard merged 1 commit intopython:mainfromjeanas:availability-i18n
Feb 12, 2023

Conversation

jeanas
Copy link
Contributor

@jeanasjeanas commentedFeb 12, 2023
edited by bedevere-bot
Loading

If the directive has content, the previous code would nest paragraph nodes from that content inside a general paragraph node, which confuses Sphinx and leads it to drop the content when translating. Instead, use a container node for the body.

Also use set_source_info so that any warnings have location info.

christopheNan reacted with thumbs up emoji
If the directive has content, the previous code would nest paragraphnodes from that content inside a general paragraph node, which confusesSphinx and leads it to drop the content when translating. Instead, use acontainer node for the body.Also use set_source_info so that any warnings have location info.
@jeanas
Copy link
ContributorAuthor

@jeanas
Copy link
ContributorAuthor

I guess this can skip NEWS?

@jeanas
Copy link
ContributorAuthor

Also CC@AA-Turner, maybe you want to take a look?

@arhadthedevarhadthedev added docsDocumentation in the Doc dir skip news buildThe build process and cross-build labelsFeb 12, 2023
@JulienPalard
Copy link
Member

I tested it on an english and a french build: it works as expected.

@jeanasjeanas deleted the availability-i18n branchFebruary 12, 2023 14:33
@jeanas
Copy link
ContributorAuthor

Thanks for merging!

@jeanas
Copy link
ContributorAuthor

BTW, this needs to be backported, right?

christopheNan reacted with thumbs up emoji

@JulienPalard
Copy link
Member

BTW, this needs to be backported, right?

Right.

@JulienPalardJulienPalard added the needs backport to 3.11only security fixes labelFeb 12, 2023
@miss-islington
Copy link
Contributor

Thanks@jeanas for the PR, and@JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-101852 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelFeb 12, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 12, 2023
…honGH-101846)pyspecific: Fix i18n for availability directiveIf the directive has content, the previous code would nest paragraphnodes from that content inside a general paragraph node, which confusesSphinx and leads it to drop the content when translating. Instead, use acontainer node for the body.Also use set_source_info so that any warnings have location info.(cherry picked from commit6ef6915)Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
@JulienPalard
Copy link
Member

It'll need a backport to 3.10 too but will probabily not succeed automatically.

@JulienPalardJulienPalard added the needs backport to 3.10only security fixes labelFeb 12, 2023
@miss-islington
Copy link
Contributor

Thanks@jeanas for the PR, and@JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@jeanas and@JulienPalard, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 6ef6915d3530e844243893f91bf4bd702dfef570 3.10

miss-islington added a commit that referenced this pull requestFeb 12, 2023
pyspecific: Fix i18n for availability directiveIf the directive has content, the previous code would nest paragraphnodes from that content inside a general paragraph node, which confusesSphinx and leads it to drop the content when translating. Instead, use acontainer node for the body.Also use set_source_info so that any warnings have location info.(cherry picked from commit6ef6915)Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
carljm added a commit to carljm/cpython that referenced this pull requestFeb 13, 2023
* main:pythongh-101810: Remove duplicated st_ino calculation (pythonGH-101811)pythongh-92547: Purge sqlite3_enable_shared_cache() detection from configure (python#101873)pythonGH-100987: Refactor `_PyInterpreterFrame` a bit, to assist generator improvement. (pythonGH-100988)pythonGH-87849: Simplify stack effect of SEND and specialize it for generators and coroutines. (pythonGH-101788)  Correct trivial grammar in reset_mock docs (python#101861)pythongh-101845: pyspecific: Fix i18n for availability directive (pythonGH-101846)pythongh-89792: Limit test_tools freeze test build parallelism based on the number of cores (python#101841)pythongh-85984: Utilize new "winsize" functions from termios in pty tests. (python#101831)pythongh-89792: Prevent test_tools from copying 1000M of "source" in freeze test (python#101837)  Fix typo in test_fstring.py (python#101823)pythonGH-101797: allocate `PyExpat_CAPI` capsule on heap (python#101798)pythongh-101390: Fix docs for `imporlib.util.LazyLoader.factory` to properly call it a class method (pythonGH-101391)
@ZeroIntensityZeroIntensity removed the needs backport to 3.10only security fixes labelFeb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JulienPalardJulienPalardJulienPalard approved these changes

Assignees

@JulienPalardJulienPalard

Labels
buildThe build process and cross-builddocsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@jeanas@JulienPalard@miss-islington@bedevere-bot@arhadthedev@ZeroIntensity

[8]ページ先頭

©2009-2025 Movatter.jp