Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-101810: Remove duplicated st_ino calculation#101811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The deleted `status->st_ino = (((uint64_t)info.nFileIndexHigh) << 32) + info.nFileIndexLow;` is already calculated and assigned in the function `_Py_attribute_data_to_stat()`.So removing the duplicated code.
ghost commentedFeb 10, 2023 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
bedevere-bot commentedFeb 10, 2023
Most changes to Pythonrequire a NEWS entry. Please add it using theblurb_it web app or theblurb command-line tool. |
Seems like we don't need a NEWS entry for removing duplicated code, IMO. |
* main:pythongh-101810: Remove duplicated st_ino calculation (pythonGH-101811)pythongh-92547: Purge sqlite3_enable_shared_cache() detection from configure (python#101873)pythonGH-100987: Refactor `_PyInterpreterFrame` a bit, to assist generator improvement. (pythonGH-100988)pythonGH-87849: Simplify stack effect of SEND and specialize it for generators and coroutines. (pythonGH-101788) Correct trivial grammar in reset_mock docs (python#101861)pythongh-101845: pyspecific: Fix i18n for availability directive (pythonGH-101846)pythongh-89792: Limit test_tools freeze test build parallelism based on the number of cores (python#101841)pythongh-85984: Utilize new "winsize" functions from termios in pty tests. (python#101831)pythongh-89792: Prevent test_tools from copying 1000M of "source" in freeze test (python#101837) Fix typo in test_fstring.py (python#101823)pythonGH-101797: allocate `PyExpat_CAPI` capsule on heap (python#101798)pythongh-101390: Fix docs for `imporlib.util.LazyLoader.factory` to properly call it a class method (pythonGH-101391)
@zooba, do you plan to backport this fix to 3.10 and 3.11? 3.10.11 is scheduled to be released on 3 April. It's the last bugfix release for 3.10. |
It's not really a bug fix though, and I didn't go through older versions to make sure it's duplicated there (and the backport PR won't detect it if it's not). |
Okay, just saw that you checked out the history on the issue. But I've been told off once this week for backporting perf-only changes, so I think I'll leave this one where it is. |
The deleted
status->st_ino = (((uint64_t)info.nFileIndexHigh) << 32) + info.nFileIndexLow;is already calculated and assigned in the function_Py_attribute_data_to_stat(). So removing the duplicated code.