gh-101765: Fix SystemError / segmentation fault in iter`reduce` when internal access of`builtins.dict` exhausts the iterator#101769

Merged

JelleZijlstra merged 24 commits intopython:mainfrom

ionite34:fix-reduce

Feb 24, 2023

Merged

gh-101765: Fix SystemError / segmentation fault in iter `reduce` when internal access of `builtins.dict` exhausts the iterator#101769
JelleZijlstra merged 24 commits intopython:mainfrom
ionite34:fix-reduce

Commits

Commits on Feb 10, 2023

Fix undefined behavior in listiter_reduce from _PyEval_GetBuiltin side effects
ionite34
committed
Update comment to not mention `__eq__`
ionite34
committed
Fix undefined behavior in iter_reduce and calliter_reduce
ionite34
committed
Update listiter_reduce_general comment
ionite34
committed
Fix undefined behavior in bytearrayiter_reduce from _PyEval_GetBuiltin side effects
ionite34
committed
Fix undefined behavior in striter_reduce from _PyEval_GetBuiltin side effects
ionite34
committed
Fix undefined behavior in tupleiter_reduce from _PyEval_GetBuiltin side effects
ionite34
committed
Move iter call in unicodeiter_reduce before `it` pointer access due to potential side effects
ionite34
committed
Add iter reduce tests for issue #101765
ionite34
committed
Remove C++ reference in comments
ionite34
committed
Remove C++ reference in comments
ionite34
committed
Move builtin declarations inside if blocks
ionite34
committed
Move _PyEval_GetBuiltin before gi checks, add gi NULL check in ga_iter_reduce
ionite34
committed
Update iter reduce mutating tests for generic alias
ionite34
committed
📜🤖 Added by blurb_it.
blurb-it[bot]
authored
Fix backticks format for news
ionite34
committed
Refactor iter reduce builtins mutation tests
ionite34
committed
Update iter mutating builtins test to include reversed iterator for list conditional branch
ionite34
committed
Add comment in unicodeiter_reduce for moving iter call before it pointers
ionite34
committed
Change test `__builtins__` to builtins import
ionite34
committed
Change NEWS blurb phrasing
ionite34
committed
Update iter reduce mutating builtins test comments and simplify logic
ionite34
committed

Commits on Feb 24, 2023

Update comments to better reflect issue
ionite34
committed
Clarify test comments
ionite34
committed

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-101765: Fix SystemError / segmentation fault in iter`reduce` when internal access of`builtins.dict` exhausts the iterator#101769

gh-101765: Fix SystemError / segmentation fault in iter `reduce` when internal access of `builtins.dict` exhausts the iterator#101769
JelleZijlstra merged 24 commits intopython:mainfrom
ionite34:fix-reduce

Commits

Commits on Feb 10, 2023

Fix undefined behavior in listiter_reduce from _PyEval_GetBuiltin side effects

Update comment to not mention `eq`

Fix undefined behavior in iter_reduce and calliter_reduce

Update listiter_reduce_general comment

Fix undefined behavior in bytearrayiter_reduce from _PyEval_GetBuiltin side effects

Fix undefined behavior in striter_reduce from _PyEval_GetBuiltin side effects

Fix undefined behavior in tupleiter_reduce from _PyEval_GetBuiltin side effects

Move iter call in unicodeiter_reduce before `it` pointer access due to potential side effects

Add iter reduce tests for issue #101765

Remove C++ reference in comments

Remove C++ reference in comments

Move builtin declarations inside if blocks

Move _PyEval_GetBuiltin before gi checks, add gi NULL check in ga_iter_reduce

Update iter reduce mutating tests for generic alias

📜🤖 Added by blurb_it.

Fix backticks format for news

Refactor iter reduce builtins mutation tests

Update iter mutating builtins test to include reversed iterator for list conditional branch

Add comment in unicodeiter_reduce for moving iter call before it pointers

Change test `builtins` to builtins import

Change NEWS blurb phrasing

Update iter reduce mutating builtins test comments and simplify logic

Commits on Feb 24, 2023

Update comments to better reflect issue

Clarify test comments

Movatterモバイル変換

Uh oh!

gh-101765: Fix SystemError / segmentation fault in iter `__reduce__` when internal access of `builtins.__dict__` exhausts the iterator#101769JelleZijlstra merged 24 commits intopython:mainpython/cpython:mainfromionite34:fix-reduceionite34/cpython:fix-reduceCopy head branch name to clipboard

Commits

Commits on Feb 10, 2023

Commits on Feb 24, 2023

gh-101765: Fix SystemError / segmentation fault in iter `reduce` when internal access of `builtins.dict` exhausts the iterator#101769
JelleZijlstra merged 24 commits intopython:mainfrom
ionite34:fix-reduce