NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-101670: typo fix in PyImport_ExtendInittab()#101723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hugovk merged 2 commits intopython:mainfromskirpichev:amend-101672

Feb 9, 2023

Merged

gh-101670: typo fix in PyImport_ExtendInittab()#101723

hugovk merged 2 commits intopython:mainfromskirpichev:amend-101672

Feb 9, 2023

Conversation

Copy link

Contributor

skirpichev commentedFeb 9, 2023•
edited by ericsnowcurrently
Loading

This fixes the other typo from commit7f3a4b9. (Also seegh-101672.)

Issue:Grammatical error in message string forFatalError when callingPyImport_AppendInittab() afterPy_Initialize() #101670

pythongh-101670: Amend35dd550

3eeb959

skirpichev requested review frombrettcannon,encukou,ericsnowcurrently,ncoghlan andwarsaw ascode owners

February 9, 2023 00:30

bedevere-bot added the awaiting review label

Feb 9, 2023

bedevere-bot mentioned this pull request

Feb 9, 2023

Grammatical error in message string forFatalError when callingPyImport_AppendInittab() afterPy_Initialize()#101670

Closed

ericsnowcurrently changed the title~~gh-101670: Amend 35dd55005e~~gh-101670: typo fix in PyImport_ExtendInittab()

Feb 9, 2023

ericsnowcurrently approved these changes

Feb 9, 2023

View reviewed changes

Copy link

Member

ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

bedevere-bot added awaiting merge and removed awaiting review labels

Feb 9, 2023

Merge branch 'main' into amend-101672

77639dc

hugovk added the skip news label

Feb 9, 2023

hugovk approved these changes

Feb 9, 2023

View reviewed changes

hugovk merged commitcb24118 intopython:main

Feb 9, 2023

bedevere-bot removed the awaiting merge label

Feb 9, 2023

Copy link

Member

ericsnowcurrently commentedFeb 9, 2023

Thanks for the fix and the careful attention,@skirpichev!

(and thanks@hugovk for merging this)

carljm added a commit to carljm/cpython that referenced this pull request

Feb 9, 2023

Merge branch 'main' into inlinecomp2

be3becc

* main: (82 commits)pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723)pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736)  no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731)pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730)pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679)pythongh-85984: Remove legacy Lib/pty.py code. (python#92365)pythongh-98831: Use opcode metadata for stack_effect() (python#101704)pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719)pythongh-101283: Fix use of unbound variable (pythonGH-101712)pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286)pythongh-101277: Port more itertools static types to heap types (python#101304)pythongh-98831: Modernize CALL and family (python#101508)pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697)pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329)pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672)pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324)pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615)pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934)pythonGH-101578: Normalize the current exception (pythonGH-101607)pythongh-47937: Note that Popen attributes are read-only (python#93070)  ...