Feb 8, 2023 · Feb 8, 2023 · Feb 8, 2023 · Feb 8, 2023 · Feb 8, 2023
diff --git a/Lib/subprocess.py b/Lib/subprocess.py
                            raise FileNotFoundError('shell not found: neither %ComSpec% nor %SystemRoot% is set')
                    if os.path.isabs(comspec):
                        executable = comspec
                else:
                    comspec = executable

                args = '{} /c "{}"'.format (comspec, args)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1494,6 +1494,8 @@ def _execute_child(self, args, executable, preexec_fn, close_fds,
		raise FileNotFoundError('shell not found: neither %ComSpec% nor %SystemRoot% is set')
		if os.path.isabs(comspec):
		executable = comspec
		else:
		comspec = executable

		args = '{} /c "{}"'.format (comspec, args)
Comment on lines +1498 to 1500 Copy link Contributor eryksunFeb 8, 2023• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. The value of`args` should quote`comspec`. Otherwise the shell process won't parse its command line correctly if`comspec` contains spaces. Copy link MemberAuthor zoobaFeb 8, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. That was a problem before too, so let's make it a new issue. Assuming the backports for the original change go it, it'll automatically flow back smoothly enough (whereas this PR may not).

Expand Down