Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286)#101711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ue on Windows (pythonGH-101286)(cherry picked from commit23751ed)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Uh oh!
There was an error while loading.Please reload this page.
| @@ -111,6 +111,14 @@ underlying :class:`Popen` interface can be used directly. | |||
| Added the *text* parameter, as a more understandable alias of *universal_newlines*. | |||
| Added the *capture_output* parameter. | |||
| .. versionchanged:: 3.11.2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this version number is wrong everywhere. 3.11.2 was just released.
bedevere-bot commentedFeb 8, 2023
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
| @@ -111,6 +111,14 @@ underlying :class:`Popen` interface can be used directly. | |||
| Added the *text* parameter, as a more understandable alias of *universal_newlines*. | |||
| Added the *capture_output* parameter. | |||
| .. versionchanged:: 3.11.2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ..versionchanged::3.11.2 | |
| ..versionchanged::3.11.3 |
| @@ -488,6 +496,14 @@ functions. | |||
| *executable* parameter accepts a bytes and :term:`path-like object` | |||
| on Windows. | |||
| .. versionchanged:: 3.11.2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ..versionchanged::3.11.2 | |
| ..versionchanged::3.11.3 |
| @@ -1160,6 +1176,14 @@ calls these functions. | |||
| .. versionchanged:: 3.3 | |||
| *timeout* was added. | |||
| .. versionchanged:: 3.11.2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ..versionchanged::3.11.2 | |
| ..versionchanged::3.11.3 |
| @@ -1192,6 +1216,14 @@ calls these functions. | |||
| .. versionchanged:: 3.3 | |||
| *timeout* was added. | |||
| .. versionchanged:: 3.11.2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ..versionchanged::3.11.2 | |
| ..versionchanged::3.11.3 |
| @@ -1247,6 +1279,14 @@ calls these functions. | |||
| .. versionadded:: 3.7 | |||
| *text* was added as a more readable alias for *universal_newlines*. | |||
| .. versionchanged:: 3.11.2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ..versionchanged::3.11.2 | |
| ..versionchanged::3.11.3 |
Whoops 😆 Forgot that hitting approve would merge it immediately #101719 will backport to it at least |
Uh oh!
There was an error while loading.Please reload this page.
(cherry picked from commit23751ed)
Co-authored-by: Oleg Iaryginoleg@arhadthedev.net