Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-101693: In sqlite3, deprecate using named placeholders with parameters supplied as a sequence#101698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
erlend-aasland merged 16 commits intopython:mainfromerlend-aasland:no-numeric-placeholder-for-youFeb 15, 2023
+59 −1
Merged
gh-101693: In sqlite3, deprecate using named placeholders with parameters supplied as a sequence#101698
Changes from1 commit
Commits
Show all changes
16 commits Select commitHold shift + click to select a range
b693895 gh-101698: Deprecate using named placeholders with sequences
erlend-aasland483e4d6 Update docs
erlend-aaslande826428 Document deprecation in reference
erlend-aasland132a6ee Also test executemany
erlend-aasland31cc188 Revert "Also test executemany"
erlend-aasland660a742 Sync with main
erlend-aaslanda18d0bb Address review: add test for query with more than one named param
erlend-aasland3f94201 Address review: add PyErr_WarnFormat error handling
erlend-aasland997ccc6 Sync with main
erlend-aaslandcb091af Pull in main
erlend-aasland450cdcc Fixup
erlend-aasland841e8a4 Apply Serhiy's suggestion
erlend-aasland3e7b680 Pull in main
erlend-aasland38d1110 Address Alex's review
erlend-aaslandcf3cfc8 Also amend NEWS and What's New
erlend-aasland1687b65 Use deprecated-removed
erlend-aaslandFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Apply Serhiy's suggestion
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit841e8a4609962468a375de44bfd84c410db47f89
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1437,7 +1437,7 @@ Cursor objects | ||
| :raises DeprecationWarning: | ||
erlend-aasland marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| If :ref:`named placeholders <sqlite3-placeholders>` are used | ||
| and *parameters* is a sequence instead of a :class:`dict`. | ||
| If :attr:`~Connection.autocommit` is | ||
| :data:`LEGACY_TRANSACTION_CONTROL`, | ||
| @@ -1478,7 +1478,7 @@ Cursor objects | ||
| :raises DeprecationWarning: | ||
| If :ref:`named placeholders <sqlite3-placeholders>` are used | ||
| and the items in *parameters* are sequences instead of :class:`dict`\s. | ||
| Example: | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.