NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-101670: typo fix in PyImport_AppendInittab()#101672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

miss-islington merged 1 commit intopython:mainfromskirpichev:fix-101670

Feb 8, 2023

Merged

gh-101670: typo fix in PyImport_AppendInittab()#101672

miss-islington merged 1 commit intopython:mainfromskirpichev:fix-101670

Feb 8, 2023

Conversation

Copy link

Contributor

skirpichev commentedFeb 8, 2023•
edited by miss-islington
Loading

Issue:Grammatical error in message string forFatalError when callingPyImport_AppendInittab() afterPy_Initialize() #101670

Automerge-Triggered-By: GH:ericsnowcurrently

pythongh-101670: typo fix in PyImport_AppendInittab()

490ce18

skirpichev requested review frombrettcannon,encukou,ericsnowcurrently,ncoghlan andwarsaw ascode owners

February 8, 2023 02:38

bedevere-bot added the awaiting review label

Feb 8, 2023

bedevere-bot mentioned this pull request

Feb 8, 2023

Grammatical error in message string forFatalError when callingPyImport_AppendInittab() afterPy_Initialize()#101670

Closed

hugovk added the skip news label

Feb 8, 2023

hugovk approved these changes

Feb 8, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Feb 8, 2023

hugovk removed the skip news label

Feb 8, 2023

Copy link

Member

hugovk commentedFeb 8, 2023

Is a news file needed?

I think a backport to 3.11 and 3.10 would be useful.

hugovk added needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Feb 8, 2023

Copy link

Member

arhadthedev commentedFeb 8, 2023

Is a news file needed?

@hugovk I think no because it's a typo, not a factual mistake.

hugovk added the skip news label

Feb 8, 2023

ericsnowcurrently approved these changes

Feb 8, 2023

View reviewed changes

Copy link

Member

ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

ericsnowcurrently added the 🤖 automerge label

Feb 8, 2023

miss-islington merged commit35dd550 intopython:main

Feb 8, 2023

Copy link

Contributor

miss-islington commentedFeb 8, 2023

Thanks@skirpichev for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

Feb 8, 2023

Copy link

Contributor

miss-islington commentedFeb 8, 2023

Sorry@skirpichev, I had trouble checking out the3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 35dd55005ee9aea2843eff7f514ee689a0995df8 3.11

miss-islington self-assigned this

Feb 8, 2023

Copy link

Contributor

miss-islington commentedFeb 8, 2023

Sorry,@skirpichev, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 35dd55005ee9aea2843eff7f514ee689a0995df8 3.10

skirpichev deleted the fix-101670 branch

February 9, 2023 00:23

Copy link

ContributorAuthor

skirpichev commentedFeb 9, 2023

@hugovk, typo was added in7f3a4b9, so you can clear requirements to backport.

BTW, there are actually two typos in the commit.

hugovk removed needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Feb 9, 2023

Copy link

Member

ericsnowcurrently commentedFeb 9, 2023

BTW, thanks for fixing this (and so quickly),@skirpichev!

ericsnowcurrently mentioned this pull request

Feb 9, 2023

gh-101670: typo fix in PyImport_ExtendInittab()#101723

Merged

carljm added a commit to carljm/cpython that referenced this pull request

Feb 9, 2023

Merge branch 'main' into inlinecomp2

be3becc

* main: (82 commits)pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723)pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736)  no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731)pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730)pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679)pythongh-85984: Remove legacy Lib/pty.py code. (python#92365)pythongh-98831: Use opcode metadata for stack_effect() (python#101704)pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719)pythongh-101283: Fix use of unbound variable (pythonGH-101712)pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286)pythongh-101277: Port more itertools static types to heap types (python#101304)pythongh-98831: Modernize CALL and family (python#101508)pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697)pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329)pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672)pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324)pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615)pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934)pythonGH-101578: Normalize the current exception (pythonGH-101607)pythongh-47937: Note that Popen attributes are read-only (python#93070)  ...