Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101632: Add a RETURN_CONST instruction#101633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 6 commits intopython:mainfrompenguin-wwy:add_return_none
Feb 7, 2023

Conversation

penguin-wwy
Copy link
Contributor

@penguin-wwypenguin-wwy commentedFeb 7, 2023•
edited by bedevere-bot
Loading

@iritkatriel
Copy link
Member

Do you see a difference in any benchmarks?

@penguin-wwy
Copy link
ContributorAuthor

I am executing pyperformance, please wait :)

@penguin-wwy
Copy link
ContributorAuthor

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

@arhadthedevarhadthedev added the performancePerformance or resource usage labelFeb 7, 2023
@iritkatriel
Copy link
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

@iritkatriel
Copy link
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results arehere.

@penguin-wwy
Copy link
ContributorAuthor

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results arehere.

Thanks. It turned out a little better than I expected.

@iritkatrieliritkatriel added the interpreter-core(Objects, Python, Grammar, and Parser dirs) labelFeb 7, 2023
@iritkatrieliritkatriel changed the titlegh-101632: Add return const instructiongh-101632: Add a RETURN_CONST instructionFeb 7, 2023
Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@iritkatrieliritkatriel added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 7, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commitafba682 🤖

If you want to schedule another build, you need to add the:hammer: test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 7, 2023
@iritkatriel
Copy link
Member

The "s390x Fedora Refleaks PR" buildbot is broken (for a few months at least). All other test runs were successful.

@iritkatrieliritkatriel merged commit753fc8a intopython:mainFeb 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

Assignees
No one assigned
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)performancePerformance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@penguin-wwy@iritkatriel@bedevere-bot@arhadthedev
[8]ページ先頭
©2009-2025 Movatter.jp