Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101561: Add typing.override decorator#101564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 10 commits intopython:mainfromstroxler:gh-101561-typing-override
Feb 27, 2023

Conversation

stroxler
Copy link
Contributor

@stroxlerstroxler commentedFeb 4, 2023•
edited
Loading

The code is pulled almost unchanged fromtyping_extensions:

Question that came up was where to put the type variable and what to name it:

  • Intyping_extensions the type variables use underscore prefixes to indicate that they are not public, buttyping doesn't appear to use that convention so I named the type variableF.
  • I couldn't put the type variable next to all of the other ones (used in generic container definitions) because it relies onCallable which is defined below. If this is a problem I could correct it using a forward reference, or we could try to rearrange the module to put special forms above type variables.

Testing the code:

First set up the repo, following instructions
athttps://devguide.python.org/ by running:

./configure --with-pydebug && make -j

Then run the typing tests:

./python -m test test_typing -v

I ran the full test suite with

./python -m test -j3

and it came back clean except for atest_grp failure which I seem to get on trunk as well - likely something in my build is misconfigured but I'm pretty sure it is unrelated to the changes here.

Make sure the docs build:

cd Docmake venvmake html

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@stroxlerstroxler changed the titlePEP 698: Add typing.override decoratorgh-101561: Add typing.override decoratorFeb 4, 2023
@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Haven't looked in depth yet at all, but we'll also need:

  • A news entry, as@bedevere-bot says
  • An entry inDoc/whatsnew/3.12.rst
  • (optionally) you can add your name toMisc/ACKS

stroxler reacted with thumbs up emoji
@arhadthedevarhadthedev added stdlibPython modules in the Lib dir topic-typing labelsFeb 4, 2023
@AlexWaygoodAlexWaygood added type-featureA feature request or enhancement 3.12only security fixes labelsFeb 4, 2023
@Fidget-Spinner
Copy link
Member

The implementation for override LGTM.

stroxler reacted with thumbs up emoji

facebook-github-bot referenced this pull request in facebook/pyre-checkFeb 9, 2023
Summary:THe `typing_extensions.override` was added a few months ago,we should support it.The `typing.override` decorator isn't landed yet, but that's okay - weshould support it in override checks; it will still raise a "no such name"method when Pyre is being run against a typeshed that doens't have it yet.The PR to add `typing.override` to CPython is out for review now:https://github.com/python/cpython/pull/101564`Reviewed By: grievejiaDifferential Revision: D43055550fbshipit-source-id: 3f51f643063afea75bf54ef38ae3a48681b99bd9
stroxlerand others added9 commitsFebruary 27, 2023 11:55
Testing:First set up the repo, following instructionsathttps://devguide.python.org/ by running:```./configure --with-pydebug && make -j```Then run the typing tests:```./python -m test test_typing -v```I ran the full test suite with```./python -m test -j3```and it came back clean except for a `test_grp` failure which I seem toget on trunk as well - likely something in my build is misconfiguredbut I'm pretty sure it is unrelated to the changes here.
Correct `s/final/override` (from reusing a similar block of documentation on the `@final` decorator)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Summary:Test Plan:Reviewers:Subscribers:Tasks:Tags:
Summary:Test Plan:Reviewers:Subscribers:Tasks:Tags:
Summary:Test Plan:Reviewers:Subscribers:Tasks:Tags:
…o6pIZ.rstCo-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Summary:Test Plan:Reviewers:Subscribers:Tasks:Tags:
@stroxlerstroxlerforce-pushed thegh-101561-typing-override branch from4a04527 to090d9d2CompareFebruary 27, 2023 19:56
@stroxler
Copy link
ContributorAuthor

(Rebase on main)

@gvanrossum Ithink this is waiting on review from you

Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry for dropping this; I have a few nits but I'm happy to merge the PR. I'll leave it open for a few days in case Guido does want to take a look himself.

stroxler reacted with thumbs up emoji
@gvanrossum
Copy link
Member

I defer to@JelleZijlstra if that's okay.

JelleZijlstra reacted with thumbs up emoji

Thanks, looks goodCo-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@sobolevn
Copy link
Member

sobolevn commentedFeb 28, 2023•
edited
Loading

Sorry for being late with a review, I've opened a follow-up for this:#102324

Thanks a lot for adding this decorator! Great work, it would be very useful! 👍

carljm added a commit to carljm/cpython that referenced this pull requestFeb 28, 2023
* main: (67 commits)pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308)pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333)pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331)pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309)  Migrate to new PSF mailgun account (python#102284)pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193)pythonGH-90744: Fix erroneous doc links in the sys module (python#101319)pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093)pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102)  IDLE: Simplify DynOptionsMenu __init__code (python#101371)pythongh-101561: Add typing.override decorator (python#101564)pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843)pythongh-101773: Optimize creation of Fractions in private methods (python#101780)pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254)pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297)pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287)pythongh-101100: Fix sphinx warnings in `types` module (python#102274)pythongh-91038: Change default argument value to `False` instead of `0` (python#31621)pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283)  [doc] Improve grammar/fix missing word (pythonGH-102060)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@TeamSpen210TeamSpen210TeamSpen210 left review comments

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

@JelleZijlstraJelleZijlstra

Labels
3.12only security fixesstdlibPython modules in the Lib dirtopic-typingtype-featureA feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

9 participants
@stroxler@bedevere-bot@Fidget-Spinner@gvanrossum@sobolevn@JelleZijlstra@TeamSpen210@AlexWaygood@arhadthedev
[8]ページ先頭
©2009-2025 Movatter.jp